Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Refactor/fix JsParserSettings for better override behavior #3297

Open
Tracked by #3727
dyc3 opened this issue Jun 26, 2024 · 4 comments
Open
Tracked by #3727

📎 Refactor/fix JsParserSettings for better override behavior #3297

dyc3 opened this issue Jun 26, 2024 · 4 comments
Assignees
Labels
S-Bug-confirmed Status: report has been confirmed as a valid bug
Milestone

Comments

@dyc3
Copy link
Contributor

dyc3 commented Jun 26, 2024

Description

We've recently found that overrides specified in configuration caused json parser settings to be overwritten, even when the override didn't specify those options. Found in #3260, fixed in #3272, see also #3273.

This task is to investigate and fix any similar issues for JsParserSettings.

@ematipico ematipico added the S-Bug-confirmed Status: report has been confirmed as a valid bug label Jun 27, 2024
@Conaclos
Copy link
Member

See also #3183

We have a similar issue with jsxRuntime.

@Sec-ant
Copy link
Member

Sec-ant commented Jun 30, 2024

I created #3317 @dyc3, I think it already addressed this issue. But there's a bigger refactoring task behind. Feel free to get involved. There're some discussions at #3310

@Conaclos
Copy link
Member

Is this issue addressed by #3317?

@Sec-ant
Copy link
Member

Sec-ant commented Jul 16, 2024

Is this issue addressed by #3317?

It will be, but given the scope of the refactoring, addressing merge conflicts has become more and more difficult with scattered commits, so I squashed all the commits. And that PR is not ready to be merged yet because I can't find time to work on it recently.

@Conaclos Conaclos added this to the Biome 2.0 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

No branches or pull requests

4 participants