Allow to remove hooks from "useExhaustiveDependencies"

[lcswillems]

Personally, I find "useExhaustiveDependencies" only useful for useMemo.

For useEffect, most of the time, it is false positives (90% of the time), because there are some times where I don't want to run effects when some variable changes, even though I use that variable in the useEffect.

However, for useMemo, all reports of the rules are good catches.

[siketyan]

I think most of those should be true positives. useEffect is not a thing to control when to run the function. That's why effects are called twice in strict mode. If you want to run an effect exactly once, you may need an event handler, not an effect.

[siketyan]

@lcswillems
It does run only on data is changed, even if logger is also in the dependencies list. If the effect runs on every render, the implementation of useLogger seems not correct, i.e. the logger is not stable. To make the logger stable, you can wrap the return value with useMemo or useRef in the useLogger implementation.

[lcswillems]

I don't see why conceptually my logger must be stable? In my case, the logger is unstable and it is fine.

[ematipico]

You can also allowlist bindings via suppression comments. That's documented in the rule page. Doesn't that cover the use case?

[arendjr]

I don't see why conceptually my logger must be stable?

That's the "contract" that React wishes to enforce on you:

Notice that you can’t “choose” the dependencies of your Effect. Every reactive value used by your Effect’s code must be declared as a dependency.

Reactive values include props, state, and all the variables and functions declared directly inside your component body.

From: https://react.dev/reference/react/useEffect#specifying-reactive-dependencies

[lcswillems]

@ematipico Do you mean adding comments in the code before each hook I don't want the check to happen? Not 100% sure which page of the documentation explains what "allowlist bindings via suppression comments" means?