feat(cli)!: rename --javascript-attribute-position to `--javascript…

…-formatter-attribute-position` (#5132) Signed-off-by: Naoki Ikeguchi <[email protected]>
biomejs · Feb 16, 2025 · 3065eb4 · 3065eb4
1 parent a41673b
commit 3065eb4
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 10 deletions.
diff --git a/.changeset/hot-moons-kiss.md b/.changeset/hot-moons-kiss.md
@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": minor
+---
+
+CLI flag `--javascript-attribute-position` was renamed to `--javascript-formatter-attribute-position` for consistency.
diff --git a/crates/biome_cli/tests/snapshots/main_commands_check/check_help.snap b/crates/biome_cli/tests/snapshots/main_commands_check/check_help.snap
@@ -68,8 +68,8 @@ The configuration that is contained inside the file `biome.json`
                               JavaScript (and its super languages) files. Defaults to 80.
         --javascript-formatter-quote-style=<double|single>  The type of quotes used in JavaScript
                               code. Defaults to double.
-        --javascript-attribute-position=<multiline|auto>  The attribute position style in jsx
-                              elements. Defaults to auto.
+        --javascript-formatter-attribute-position=<multiline|auto>  The attribute position style in
+                              JSX elements. Defaults to auto.
         --javascript-object-wrap=<preserve|collapse>  Whether to enforce collapsing object literals
                               when possible. Defaults to preserve.
         --javascript-linter-enabled=<true|false>  Control the linter for JavaScript (and its super

diff --git a/crates/biome_cli/tests/snapshots/main_commands_ci/ci_help.snap b/crates/biome_cli/tests/snapshots/main_commands_ci/ci_help.snap
@@ -69,8 +69,8 @@ The configuration that is contained inside the file `biome.json`
                               JavaScript (and its super languages) files. Defaults to 80.
         --javascript-formatter-quote-style=<double|single>  The type of quotes used in JavaScript
                               code. Defaults to double.
-        --javascript-attribute-position=<multiline|auto>  The attribute position style in jsx
-                              elements. Defaults to auto.
+        --javascript-formatter-attribute-position=<multiline|auto>  The attribute position style in
+                              JSX elements. Defaults to auto.
         --javascript-object-wrap=<preserve|collapse>  Whether to enforce collapsing object literals
                               when possible. Defaults to preserve.
         --javascript-linter-enabled=<true|false>  Control the linter for JavaScript (and its super

diff --git a/crates/biome_cli/tests/snapshots/main_commands_format/format_help.snap b/crates/biome_cli/tests/snapshots/main_commands_format/format_help.snap
@@ -51,8 +51,8 @@ Formatting options specific to the JavaScript files
                               JavaScript (and its super languages) files. Defaults to 80.
         --javascript-formatter-quote-style=<double|single>  The type of quotes used in JavaScript
                               code. Defaults to double.
-        --javascript-attribute-position=<multiline|auto>  The attribute position style in jsx
-                              elements. Defaults to auto.
+        --javascript-formatter-attribute-position=<multiline|auto>  The attribute position style in
+                              JSX elements. Defaults to auto.
         --bracket-spacing=<true|false>  Whether to insert spaces around brackets in object literals.
                               Defaults to true.
         --javascript-object-wrap=<preserve|collapse>  Whether to enforce collapsing object literals

diff --git a/crates/biome_configuration/src/javascript/formatter.rs b/crates/biome_configuration/src/javascript/formatter.rs
@@ -93,8 +93,11 @@ pub struct JsFormatterConfiguration {
     pub quote_style: Option<QuoteStyle>,
 
     // it's also a top-level configurable property.
-    /// The attribute position style in jsx elements. Defaults to auto.
-    #[bpaf(long("javascript-attribute-position"), argument("multiline|auto"))]
+    /// The attribute position style in JSX elements. Defaults to auto.
+    #[bpaf(
+        long("javascript-formatter-attribute-position"),
+        argument("multiline|auto")
+    )]
     #[serde(skip_serializing_if = "Option::is_none")]
     pub attribute_position: Option<AttributePosition>,
 

diff --git a/packages/@biomejs/backend-jsonrpc/src/workspace.ts b/packages/@biomejs/backend-jsonrpc/src/workspace.ts
diff --git a/packages/@biomejs/biome/configuration_schema.json b/packages/@biomejs/biome/configuration_schema.json