fix(cli): fix CLI flag of bracketSpacing option for lang-specific o…

…verride (#5130) Signed-off-by: Naoki Ikeguchi <[email protected]> Co-authored-by: Arend van Beelen jr. <[email protected]>
biomejs · Feb 16, 2025 · 0cbbbe6 · 0cbbbe6
1 parent e9f679f
commit 0cbbbe6
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 3 deletions.
diff --git a/.changeset/funny-beans-vanish.md b/.changeset/funny-beans-vanish.md
@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed the flag `--bracket-spacing` that was duplicated between the global configuration and the language-specific override for JavaScript.
diff --git a/crates/biome_cli/tests/snapshots/main_commands_check/check_help.snap b/crates/biome_cli/tests/snapshots/main_commands_check/check_help.snap
@@ -70,6 +70,8 @@ The configuration that is contained inside the file `biome.json`
                               code. Defaults to double.
         --javascript-formatter-attribute-position=<multiline|auto>  The attribute position style in
                               JSX elements. Defaults to auto.
+        --javascript-formatter-bracket-spacing=<true|false>  Whether to insert spaces around
+                              brackets in object literals. Defaults to true.
         --javascript-object-wrap=<preserve|collapse>  Whether to enforce collapsing object literals
                               when possible. Defaults to preserve.
         --javascript-linter-enabled=<true|false>  Control the linter for JavaScript (and its super

diff --git a/crates/biome_cli/tests/snapshots/main_commands_ci/ci_help.snap b/crates/biome_cli/tests/snapshots/main_commands_ci/ci_help.snap
@@ -71,6 +71,8 @@ The configuration that is contained inside the file `biome.json`
                               code. Defaults to double.
         --javascript-formatter-attribute-position=<multiline|auto>  The attribute position style in
                               JSX elements. Defaults to auto.
+        --javascript-formatter-bracket-spacing=<true|false>  Whether to insert spaces around
+                              brackets in object literals. Defaults to true.
         --javascript-object-wrap=<preserve|collapse>  Whether to enforce collapsing object literals
                               when possible. Defaults to preserve.
         --javascript-linter-enabled=<true|false>  Control the linter for JavaScript (and its super

diff --git a/crates/biome_cli/tests/snapshots/main_commands_format/format_help.snap b/crates/biome_cli/tests/snapshots/main_commands_format/format_help.snap
@@ -53,8 +53,8 @@ Formatting options specific to the JavaScript files
                               code. Defaults to double.
         --javascript-formatter-attribute-position=<multiline|auto>  The attribute position style in
                               JSX elements. Defaults to auto.
-        --bracket-spacing=<true|false>  Whether to insert spaces around brackets in object literals.
-                              Defaults to true.
+        --javascript-formatter-bracket-spacing=<true|false>  Whether to insert spaces around
+                              brackets in object literals. Defaults to true.
         --javascript-object-wrap=<preserve|collapse>  Whether to enforce collapsing object literals
                               when possible. Defaults to preserve.
 

diff --git a/crates/biome_configuration/src/javascript/formatter.rs b/crates/biome_configuration/src/javascript/formatter.rs
@@ -103,7 +103,7 @@ pub struct JsFormatterConfiguration {
 
     // it's also a top-level configurable property.
     /// Whether to insert spaces around brackets in object literals. Defaults to true.
-    #[bpaf(long("bracket-spacing"), argument("true|false"))]
+    #[bpaf(long("javascript-formatter-bracket-spacing"), argument("true|false"))]
     #[serde(skip_serializing_if = "Option::is_none")]
     pub bracket_spacing: Option<BracketSpacing>,