Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it so the extension no longer looks only for
-musl
binaries on Linuxnode_modules
: use most appropriate package (@biomejs/cli-linux-x64-musl
on systems that use musl, and@biomejs/cli-linux-x64
on the others)-musl
flavorDescription
Some package managers do not automatically install both the
@biomejs/cli-linux-x64
and@biomejs/cli-linux-x64-musl
, but since our current logic expect the-musl
flavor to be installed, some users may have trouble getting the extension to work.This logic was initially introduced to always download the
musl
flavor when downloading Biome using the built-in downloader, but we're splitting the logic here so that we look for the most appropriate package in node modules, why still downloading themusl
flavor when downloading Biome from VS Code.This solves the issue because:
Related Issue
Fixes #502
Checklist