Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not force musl on linux #503

Merged
merged 1 commit into from
Feb 23, 2025
Merged

fix: do not force musl on linux #503

merged 1 commit into from
Feb 23, 2025

Conversation

nhedger
Copy link
Member

@nhedger nhedger commented Feb 23, 2025

Summary

This PR makes it so the extension no longer looks only for -musl binaries on Linux

  • When looking for biome in node_modules: use most appropriate package (@biomejs/cli-linux-x64-musl on systems that use musl, and @biomejs/cli-linux-x64 on the others)
  • When downloading Biome from within VS Code: always download the -musl flavor

Description

Some package managers do not automatically install both the @biomejs/cli-linux-x64 and @biomejs/cli-linux-x64-musl, but since our current logic expect the -musl flavor to be installed, some users may have trouble getting the extension to work.

This logic was initially introduced to always download the musl flavor when downloading Biome using the built-in downloader, but we're splitting the logic here so that we look for the most appropriate package in node modules, why still downloading the musl flavor when downloading Biome from VS Code.

This solves the issue because:

  1. There are no expectations of compatibility put on the user when downloading Biome from VS Code. Since we use the statically built musl flavor, it just works.
  2. We mitigate behavioral differences among the package managers.

Related Issue

Fixes #502

Checklist

  • I have tested my changes on the following platforms:
    • Windows
    • Linux
    • macOS

@nhedger nhedger requested review from a team as code owners February 23, 2025 17:00
@nhedger nhedger merged commit a895331 into main Feb 23, 2025
2 checks passed
@nhedger nhedger deleted the fix/no-musl-force branch February 23, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Biome is not found in workspace folder
1 participant