Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs misleading on pull requests #88

Open
stucka opened this issue Aug 9, 2023 · 0 comments
Open

Docs misleading on pull requests #88

stucka opened this issue Aug 9, 2023 · 0 comments

Comments

@stucka
Copy link
Collaborator

stucka commented Aug 9, 2023

The docs say to make a fork, work on it, then submit a pull request.

All such pull requests will fail automated CI testing, as there are some built-in project-level tests that require a BLN API key for testing, and forks do not have access to the environment variable / Github secret needed to pass those tests. One approach is to take a copy of the original repo; create a branch; and bring in the files from the branch for testing.

See https://github.com/biglocalnews/bln-python-client/settings/secrets/actions

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant