You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
1. Why is this change required?
2. What problem does it solve?
3. What scenario does it contribute to?
4. If it fixes an open issue, please link to the issue here.
-->
CA1591 was suppressed, so many files were missing documentation. This
removes that suppression and adds comments. I used
https://github.com/mkarle/sk-autodocs to automatically generate the
documentation.
### Description
- Unsuppressed CA1591 from top-level editorconfig but kept it suppressed
for unit tests
- Ran `dotnet build | Out-File -FilePath .\log.log` to get a log of
missing XML documentation
- Ran ` sk-autodocs --dotnet-build-log log.log` to generate
documentation for the files missing documentation
- Went through each file and (hopefully) corrected any mistakes. The
most common problems were that it would change the namespace to braces
or remove the empty line at the end.
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
---------
Co-authored-by: Lisa Harrylock <[email protected]>
Co-authored-by: Mark Wallace <[email protected]>
@@ -73,6 +77,12 @@ public LanguageCalculatorSkill(IKernel kernel)
73
77
topP:1);
74
78
}
75
79
80
+
/// <summary>
81
+
/// Calculates the result of a non-trivial math expression.
82
+
/// </summary>
83
+
/// <param name="input">A valid mathematical expression that could be executed by a calculator capable of more advanced math functions like sine/cosine/floor.</param>
84
+
/// <param name="context">The context for the skill execution.</param>
85
+
/// <returns>A <see cref="Task{TResult}"/> representing the result of the asynchronous operation.</returns>
76
86
[SKFunction,SKName("Calculator"),Description("Useful for getting the result of a non-trivial math expression.")]
77
87
publicasyncTask<string>CalculateAsync(
78
88
[Description("A valid mathematical expression that could be executed by a calculator capable of more advanced math functions like sin/cosine/floor.")]
/// HTTP Schema for streaming completion response. Adapted from <see href="https://github.com/oobabooga/text-generation-webui/blob/main/extensions/api/streaming_api.py"/>
8
+
/// Represents the HTTP schema for streaming completion response. Adapted from <see href="https://github.com/oobabooga/text-generation-webui/blob/main/extensions/api/streaming_api.py"/>.
9
9
/// </summary>
10
10
publicsealedclassTextCompletionStreamingResponse
11
11
{
12
+
/// <summary>
13
+
/// Constant string representing the event that is fired when text is received from a websocket.
@@ -20,7 +22,7 @@ public abstract class AzureOpenAIClientBase : ClientBase
20
22
privateprotectedoverrideOpenAIClientClient{get;}
21
23
22
24
/// <summary>
23
-
/// Creates a new Azure OpenAI client instance using API Key auth
25
+
/// Initializes a new instance of the <see cref="AzureOpenAIClientBase"/> class using API Key authentication.
24
26
/// </summary>
25
27
/// <param name="modelId">Azure OpenAI model ID or deployment name, see https://learn.microsoft.com/azure/cognitive-services/openai/how-to/create-resource</param>
26
28
/// <param name="endpoint">Azure OpenAI deployment URL, see https://learn.microsoft.com/azure/cognitive-services/openai/quickstart</param>
/// Creates a new Azure OpenAI client instance supporting AAD auth
55
+
/// Initializes a new instance of the <see cref="AzureOpenAIClientBase"/> class supporting AAD authentication.
54
56
/// </summary>
55
57
/// <param name="modelId">Azure OpenAI model ID or deployment name, see https://learn.microsoft.com/azure/cognitive-services/openai/how-to/create-resource</param>
56
58
/// <param name="endpoint">Azure OpenAI deployment URL, see https://learn.microsoft.com/azure/cognitive-services/openai/quickstart</param>
/// Creates a new Azure OpenAI client instance using the specified OpenAIClient
83
-
/// Note: instances created this way might not have the default diagnostics settings,
84
+
/// Initializes a new instance of the <see cref="AzureOpenAIClientBase"/> class using the specified OpenAIClient.
85
+
/// Note: instances created this way might not have the default diagnostics settings,
84
86
/// it's up to the caller to configure the client.
85
87
/// </summary>
86
88
/// <param name="modelId">Azure OpenAI model ID or deployment name, see https://learn.microsoft.com/azure/cognitive-services/openai/how-to/create-resource</param>
0 commit comments