@@ -12,7 +12,9 @@ def _get_method_type():
1212 class C (object ):
1313 def x (self ):
1414 pass
15- return type (getattr (C , 'x' ))
15+
16+ return type (getattr (C , "x" ))
17+
1618
1719_method_type = _get_method_type ()
1820
@@ -40,36 +42,39 @@ def __init__(self, **kwargs):
4042 if cls == CSVExportView :
4143 # We can stop checking once we hit CSVExportView.
4244 break
43- if hasattr (cls , ' get_fields' and type (getattr (cls , ' get_fields' )) == _method_type :
45+ if hasattr (cls , " get_fields" and isinstance (getattr (cls , " get_fields" ), _method_type ) :
4446 get_fields_overridden = True
4547 break
4648
4749 if not get_fields_overridden :
4850 if not self .fields and not self .exclude :
49- raise ImproperlyConfigured (' \' fields\ '\ '\ ''
51+ raise ImproperlyConfigured ("' fields' or 'exclude' must be specified."
5052
5153 if self .fields and self .exclude :
52- raise ImproperlyConfigured (' Specifying both \ '\ '\ '\ ''
54+ raise ImproperlyConfigured (" Specifying both 'fields' and 'exclude' is not permitted."
5355
5456 # Check that some special functions are not being overridden.
55- for function_override in ('get_context_data' , 'get_paginate_by' , 'get_allow_empty' , 'get_context_object_name' ):
56- if function_override in self .__class__ .__dict__ and \
57- type (self .__class__ .__dict__ [function_override ]) == types .FunctionType :
58- raise ImproperlyConfigured ('Overriding \' {}()\' is not permitted.' .format (function_override ))
57+ for function_override in ("get_context_data" , "get_paginate_by" , "get_allow_empty" , "get_context_object_name" ):
58+ if function_override in self .__class__ .__dict__ and isinstance (
59+ self .__class__ .__dict__ [function_override ], types .FunctionType
60+ ):
61+ raise ImproperlyConfigured ("Overriding '{}()' is not permitted." .format (function_override ))
5962
6063 if self .paginate_by :
61- raise ImproperlyConfigured (' \' {} \ '' format (self .__class__ .__name__ ))
64+ raise ImproperlyConfigured ("'{} ' does not support pagination." format (self .__class__ .__name__ ))
6265
6366 if not self .allow_empty :
64- raise ImproperlyConfigured (' \' {} \ '' format (self .__class__ .__name__ ))
67+ raise ImproperlyConfigured ("'{} ' does not support disabling allow_empty." format (self .__class__ .__name__ ))
6568
6669 if self .context_object_name :
67- raise ImproperlyConfigured ('\' {}\' does not support setting context_object_name.' .format (self .__class__ .__name__ ))
70+ raise ImproperlyConfigured (
71+ "'{}' does not support setting context_object_name." .format (self .__class__ .__name__ )
72+ )
6873
6974 def get_fields (self , queryset ):
70- """ Override if a dynamic fields are required. """
75+ """Override if a dynamic fields are required."""
7176 field_names = self .fields
72- if not field_names or field_names == ' __all__'
77+ if not field_names or field_names == " __all__"
7378 opts = queryset .model ._meta
7479 field_names = [field .name for field in opts .fields ]
7580
@@ -81,17 +86,17 @@ def get_fields(self, queryset):
8186 return field_names
8287
8388 def get_filename (self , queryset ):
84- """ Override if a dynamic filename is required. """
89+ """Override if a dynamic filename is required."""
8590 filename = self .filename
8691 if not filename :
87- filename = queryset .model ._meta .verbose_name_plural .replace (' ' , '-' )
92+ filename = queryset .model ._meta .verbose_name_plural .replace (" " , "-" )
8893 return filename
8994
9095 def get_field_value (self , obj , field_name ):
91- """ Override if a custom value or behaviour is required for specific fields. """
92- if '__' not in field_name :
93- if hasattr (obj , ' all' and hasattr (obj , ' iterator'
94- return ',' .join ([getattr (ro , field_name ) for ro in obj .all ()])
96+ """Override if a custom value or behaviour is required for specific fields."""
97+ if "__" not in field_name :
98+ if hasattr (obj , " all" and hasattr (obj , " iterator"
99+ return "," .join ([getattr (ro , field_name ) for ro in obj .all ()])
95100
96101 try :
97102 field = obj ._meta .get_field (field_name )
@@ -103,58 +108,59 @@ def get_field_value(self, obj, field_name):
103108
104109 value = field .value_from_object (obj )
105110 if field .many_to_many :
106- return ',' .join ([force_str (ro ) for ro in value ])
111+ return "," .join ([force_str (ro ) for ro in value ])
107112 elif field .choices :
108- if value is None or force_str (value ).strip () == '' :
109- return ''
113+ if value is None or force_str (value ).strip () == "" :
114+ return ""
110115 return dict (field .choices )[value ]
111116 return field .value_from_object (obj )
112117 else :
113- related_field_names = field_name .split ('__' )
118+ related_field_names = field_name .split ("__" )
114119 related_obj = getattr (obj , related_field_names [0 ])
115- related_field_name = '__' .join (related_field_names [1 :])
120+ related_field_name = "__" .join (related_field_names [1 :])
116121 return self .get_field_value (related_obj , related_field_name )
117122
118123 def get_header_name (self , model , field_name ):
119- """ Override if a custom value or behaviour is required for specific fields. """
120- if '__' not in field_name :
124+ """Override if a custom value or behaviour is required for specific fields."""
125+ if "__" not in field_name :
121126 try :
122127 field = model ._meta .get_field (field_name )
123128 except FieldDoesNotExist as e :
124129 if not hasattr (model , field_name ):
125130 raise e
126131 # field_name is a property.
127- return field_name .replace ('_' , ' ' ).title ()
132+ return field_name .replace ("_" , " " ).title ()
128133
129134 return force_str (field .verbose_name ).title ()
130135 else :
131- related_field_names = field_name .split ('__' )
136+ related_field_names = field_name .split ("__" )
132137 field = model ._meta .get_field (related_field_names [0 ])
133- assert field .is_relation
134- return self .get_header_name (field .related_model , '__' .join (related_field_names [1 :]))
138+ if not field .is_relation :
139+ raise ImproperlyConfigured (f"{ field } )
140+ return self .get_header_name (field .related_model , "__" .join (related_field_names [1 :]))
135141
136142 def get_csv_writer_fmtparams (self ):
137143 return {
138- ' dialect' : ' excel'
139- ' quoting' csv .QUOTE_ALL ,
144+ " dialect" : " excel"
145+ " quoting" csv .QUOTE_ALL ,
140146 }
141147
142148 def get (self , request , * args , ** kwargs ):
143149 queryset = self .get_queryset ()
144150
145151 field_names = self .get_fields (queryset )
146152
147- response = HttpResponse (content_type = ' text/csv'
153+ response = HttpResponse (content_type = " text/csv"
148154
149155 filename = self .get_filename (queryset )
150- if not filename .endswith (' .csv'
151- filename += ' .csv'
152- response [' Content-Disposition' = 'attachment; filename="{}"' .format (filename )
156+ if not filename .endswith (" .csv"
157+ filename += " .csv"
158+ response [" Content-Disposition" = 'attachment; filename="{}"' .format (filename )
153159
154160 writer = csv .writer (response , ** self .get_csv_writer_fmtparams ())
155161
156162 if self .specify_separator :
157- response .write (' sep={}{}' format (writer .dialect .delimiter , writer .dialect .lineterminator ))
163+ response .write (" sep={}{}" format (writer .dialect .delimiter , writer .dialect .lineterminator ))
158164
159165 if self .header :
160166 writer .writerow ([self .get_header_name (queryset .model , field_name ) for field_name in list (field_names )])
0 commit comments