You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This limitation is mentioned in the README's usage section, or else it would be a bug instead of an enhancement.
Acceptance Criteria
Arguments can be passed to gh fzf in the same format they are passed to gh, e.g. without escaping quotes.
Relevant Info
The quotes need to be escaped because the arguments are saved in the FZF_DEFAULT_COMMAND environment variable, which is how the list reloading and filtering works. This follows an example from fzf's readme.
I attempted to escape the quotes with printf:
escape() { printf"%q""$@"; }
This worked for simple use cases, but not ones where quotes are nested like the example in the description.
This is a shell quirk, so I will probably need to do a golang rewrite to fix the issue.
The text was updated successfully, but these errors were encountered:
benelan
changed the title
Feat: support arguments containing whitespace without needing to escape the quotes
Feature: support arguments containing whitespace without needing to escape the quotes
May 18, 2024
Description
Currently all quotes in the arguments passed to
gh fzf
need to be escaped. For example, withgh
, you can do:gh issue list -S 'label:"known issue" milestone:"back burner"'
However, you need to escape the quotes to view that list with
gh fzf
, which shouldn't be a requirement:This limitation is mentioned in the README's usage section, or else it would be a bug instead of an enhancement.
Acceptance Criteria
Arguments can be passed to
gh fzf
in the same format they are passed togh
, e.g. without escaping quotes.Relevant Info
The quotes need to be escaped because the arguments are saved in the
FZF_DEFAULT_COMMAND
environment variable, which is how the list reloading and filtering works. This follows an example fromfzf
's readme.I attempted to escape the quotes with
printf
:This worked for simple use cases, but not ones where quotes are nested like the example in the description.
This is a shell quirk, so I will probably need to do a golang rewrite to fix the issue.
The text was updated successfully, but these errors were encountered: