Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.0.3 added rules_shell dependency #1334

Open
johanbrandhorst opened this issue Feb 15, 2025 · 0 comments
Open

v8.0.3 added rules_shell dependency #1334

johanbrandhorst opened this issue Feb 15, 2025 · 0 comments

Comments

@johanbrandhorst
Copy link

Hi! I'm the maintainer of the grpc-gateway. An automated dependency update to bazel buildtools v8.0.3 broke our bazel buildifier job. The error looks like this:

bazel run //:buildifier && git diff --exit-code
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Analyzing: target //:buildifier (0 packages loaded, 0 targets configured)
Analyzing: target //:buildifier (0 packages loaded, 0 targets configured)

ERROR: error loading package '@@+non_module_deps+com_github_bazelbuild_buildtools//buildifier': Unable to find package for @@[unknown repo 'rules_shell' requested from @@+non_module_deps+com_github_bazelbuild_buildtools]//shell:sh_test.bzl: The repository '@@[unknown repo 'rules_shell' requested from @@+non_module_deps+com_github_bazelbuild_buildtools]' could not be resolved: No repository visible as '@rules_shell' from repository '@@+non_module_deps+com_github_bazelbuild_buildtools'.
ERROR: /__w/grpc-gateway/grpc-gateway/BUILD.bazel:8:11: every rule of type _buildifier implicitly depends upon the target '@@+non_module_deps+com_github_bazelbuild_buildtools//buildifier:buildifier', but this target could not be found because of: error loading package '@@+non_module_deps+com_github_bazelbuild_buildtools//buildifier': Unable to find package for @@[unknown repo 'rules_shell' requested from @@+non_module_deps+com_github_bazelbuild_buildtools]//shell:sh_test.bzl: The repository '@@[unknown repo 'rules_shell' requested from @@+non_module_deps+com_github_bazelbuild_buildtools]' could not be resolved: No repository visible as '@rules_shell' from repository '@@+non_module_deps+com_github_bazelbuild_buildtools'.
ERROR: Analysis of target '//:buildifier' failed; build aborted: Analysis failed

I think the significant part is

unknown repo 'rules_shell' requested from non_module_deps com_github_bazelbuild_buildtools

Full build log.

Nothing in the release notes mentions this new dependency. Was it added intentionally? How are users supposed to depend on the buildtools now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant