Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bazel CI] Downstream project broken by rules_java upgrade #23619

Open
meteorcloudy opened this issue Sep 13, 2024 · 5 comments
Open

[Bazel CI] Downstream project broken by rules_java upgrade #23619

meteorcloudy opened this issue Sep 13, 2024 · 5 comments
Labels
breakage P1 I'll work on this now. (Assignee required) team-Rules-Java Issues for Java rules type: bug

Comments

@meteorcloudy
Copy link
Member

meteorcloudy commented Sep 13, 2024

(04:10:49) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/67c259e1fb9766950734b85418b03ced/external/rules_java_builtin/toolchains/BUILD:285:14: While resolving toolchains for target @@rules_java_builtin//toolchains:platformclasspath (4f6c53c): No matching toolchains found for types @@rules_java_builtin//toolchains:bootstrap_runtime_toolchain_type.
To debug, rerun with --toolchain_resolution_debug='@@rules_java_builtin//toolchains:bootstrap_runtime_toolchain_type'

Bisect points to f92124a

@meteorcloudy meteorcloudy added type: bug P1 I'll work on this now. (Assignee required) breakage team-Rules-Java Issues for Java rules labels Sep 13, 2024
@meteorcloudy
Copy link
Member Author

@hvadehra Looks like #23571 is getting cherry-picked back to 7.4, you probably want to fix this one to make sure the upgrade is backwards compatible?

@meteorcloudy
Copy link
Member Author

I bisected with rules_android using

bazel --bisect=c364bd65eee1b5b0874de85f41c39c2d6915ff8b..HEAD build --enable_workspace --noenable_bzlmod --nobuild //test/rules/...

@meteorcloudy
Copy link
Member Author

kythe/kythe#6138 might be the same issue

@hvadehra
Copy link
Member

cc @comius

@hvadehra
Copy link
Member

Looks like the failures are only when using WORKSPACE, and not with bzlmod. So presumably they're picking up an older version of rules_java?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakage P1 I'll work on this now. (Assignee required) team-Rules-Java Issues for Java rules type: bug
Projects
None yet
Development

No branches or pull requests

2 participants