Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Support layering_check with C++ path mapping #23178

Closed
bazel-io opened this issue Jul 31, 2024 · 3 comments
Closed

[7.4.0] Support layering_check with C++ path mapping #23178

bazel-io opened this issue Jul 31, 2024 · 3 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #22957
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Jul 31, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/rules/cpp/CcStarlarkInternal.java
src/main/java/com/google/devtools/build/lib/rules/cpp/CppModuleMapAction.java

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/rules/cpp/CcStarlarkInternal.java src/main/java/com/google/devtools/build/lib/rules/cpp/CppModuleMapAction.java

cc: @bazelbuild/triage

@fmeum @comius

@fmeum fmeum mentioned this issue Sep 19, 2024
Merged
@iancha1992
Copy link
Member

Cherry-picked in #23671

github-merge-queue bot pushed a commit that referenced this issue Sep 23, 2024
@fmeum
[7.4.0] Support layering_check with C++ path mapping (#23671)
fd83239 
Users can opt into path mapping for C++ module map actions via
`--modify_execution_info=CppModuleMap=+supports-path-mapping`. This is
achieved by mapping paths in the module map files as well as converting
the sequence variable for module map paths to a new structured
`ArtifactSequenceVariable`.

Also makes it so that `ExecutionServer` gracefully handles failing
commands instead of crashing.

Closes #22957.

PiperOrigin-RevId: 675073116
Change-Id: I13835c7fb01354a89ec5fd141cf892c6b733efe4

Fixes #23178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @iancha1992