You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
**What type of PR is this?**
Bug fix
**What does this PR do? Why is it needed?**
[Go 1.24](https://go.dev/doc/go1.24#wasm) added support for `GOOS=wasip1
GOARCH=wasm go build -buildmode=c-shared`; however, the rules_go
starlark code contained validation against this.
* Fixes validation error in newly supported go 1.24 wasip1-wasm tuple
with -buildmode=c-shared.
* Removes lib prefix for wasip1 -buildmode=c-shared
* Adds `.wasm` suffix for wasi reactors built with `-buildmode=c-shared`
**Which issues(s) does this PR fix?**
Fixes#4200
**Other notes for review**
It looks like this could use a test (as simple as adding a new go file
under `tests/core/c_linkmodes/`); however, the support for features
added in this PR requires Go 1.24, which is not out yet. Updating
`go_register_toolchains(version = "1.24rc1")` does allow it to build,
but then `nogo` fails due to lack of support in some of the linters for
go 1.24.
Signed-off-by: Matt Leon <[email protected]>
fail(("linkmode '{}' can't be used when cgo is disabled. Check that pure is not set to \"off\" and that a C/C++ toolchain is configured for "+
70
70
"your current platform. If you defined a custom platform, make sure that it has the @io_bazel_rules_go//go/toolchain:cgo_on constraint value.").format(mode.linkmode))
0 commit comments