Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support renamed errors in aws-json-1.1 protocol #804

Open
1 task
everett1992 opened this issue Jan 5, 2023 · 1 comment
Open
1 task

Support renamed errors in aws-json-1.1 protocol #804

everett1992 opened this issue Jan 5, 2023 · 1 comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue queued This issues is on the AWS team's backlog

Comments

@everett1992
Copy link

Describe the feature

Smithy recently allowed renaming error shapes but added a validator to prevent renamed errors with aws protocols.

Most aws protocols only use shape name in error serialization, which is why error renames were originally banned. However, aws json 1.0 uses qualified shape id and can support renamed errors.

The protocol should match errors based on the original (not renamed) fully qualified shape id.

Once all smithy sdk's (rust, js, go, kotlin) confirm that aws json 1.0 supports renamed errors smithy can remove the protocol from the validator and allow renames.

smithy-lang/smithy#1545

Is your Feature Request related to a problem?

I have smithy a smithy model with shapes with conflicting names, tho the qualified shape id is unique. I'd like to use aws json 1.0 protocol, which could support renamed error shapes, but the validator throws an error.

Proposed Solution

No response

Describe alternative solutions or features you've considered

No response

Acknowledge

  • I may be able to implement this feature request

AWS Kotlin SDK version used

N/A

Platform (JVM/JS/Native)

N/A

Operating System and version

N/A

@everett1992 everett1992 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2023
@ianbotsf
Copy link
Contributor

ianbotsf commented Jan 6, 2023

Thanks for the feature request, @everett1992. We'd like to support this feature of aws-json-1.1 but, since no published AWS service models use this, we won't be prioritizing this immediately. I'll leave this open as a tracking issue and provide an update when we begin/complete the work.

@ianbotsf ianbotsf removed the needs-triage This issue or PR still needs to be triaged. label Jan 6, 2023
@RanVaknin RanVaknin added p3 This is a minor priority issue queued This issues is on the AWS team's backlog labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

3 participants