appease clippy

Author: graebm

aws-s3-transfer-manager/src/metrics.rs

@@ -284,7 +284,7 @@ pub struct ThroughputDisplayContext<'a> {
     pub unit: unit::ByteUnit,
 }
 
-impl<'a> fmt::Display for ThroughputDisplayContext<'a> {
+impl fmt::Display for ThroughputDisplayContext<'_> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         if let Some(precision) = f.precision() {
             write!(

aws-s3-transfer-manager/src/operation/upload/checksum_strategy.rs

@@ -251,7 +251,7 @@ impl Builder {
             }
         };
 
-        if self.full_object_checksum.is_some() && &type_if_multipart != &ChecksumType::FullObject {
+        if self.full_object_checksum.is_some() && type_if_multipart != ChecksumType::FullObject {
             return Err(BuildError::invalid_field("full_object_checksum",
                 format!("You cannot provide the full object checksum value up front when the multipart checksum type is `{type_if_multipart}` (algorithm is `{algorithm}`)")
             ));

aws-s3-transfer-manager/tests/download_test.rs

@@ -21,9 +21,9 @@ use aws_smithy_runtime::client::http::test_util::{ReplayEvent, StaticReplayClien
 use aws_smithy_types::body::SdkBody;
 use bytes::{BufMut, Bytes, BytesMut};
 
-/// NOTE: these tests are somewhat brittle as they assume particular paths through the codebase.
-/// As an example we generally assume object discovery goes through `GetObject` with a ranged get
-/// for the first part.
+// NOTE: these tests are somewhat brittle as they assume particular paths through the codebase.
+// As an example we generally assume object discovery goes through `GetObject` with a ranged get
+// for the first part.
 
 fn rand_data(size: usize) -> Bytes {
     iter::repeat_with(fastrand::alphanumeric)

aws-s3-transfer-manager/tests/upload_checksum_test.rs

@@ -138,7 +138,7 @@ pin_project! {
 impl TestStream {
     pub fn new(parts: Vec<Bytes>) -> Self {
         TestStream {
-            parts: parts,
+            parts,
             next_part_num: 1,
         }
     }
@@ -347,8 +347,8 @@ fn mock_s3_client_for_put_object(
     let mut mock_client_rules: Vec<Rule> = Vec::new();
 
     // Pre-calculate stuff for later
-    let checksum_value = calculate_checksum(&response_algorithm, &expected_body);
-    let etag = calculate_etag(&expected_body);
+    let checksum_value = calculate_checksum(&response_algorithm, expected_body);
+    let etag = calculate_etag(expected_body);
 
     // PutObject
     mock_client_rules.push(
@@ -477,7 +477,7 @@ async fn upload_helper(
         s3_client
             .config()
             .to_builder()
-            .request_checksum_calculation(sdk_checksum_calculation.clone())
+            .request_checksum_calculation(sdk_checksum_calculation)
             .build(),
     );