Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing userNotFound field in "create/verify auth challenge" Cognito user pool events #718

Closed
kikuomax opened this issue Nov 4, 2023 · 1 comment · Fixed by #719
Closed

Missing userNotFound field in "create/verify auth challenge" Cognito user pool events #718

kikuomax opened this issue Nov 4, 2023 · 1 comment · Fixed by #719

Comments

@kikuomax
Copy link
Contributor

kikuomax commented Nov 4, 2023

According to AWS documentation, "create/verify auth challenge" Cognito user pool events should have userNotFound field, and they did as far as I tested on my AWS account. However, user_not_found fields are missing in:

They should have user_not_found field similar to CognitoEventUserPoolsDefineAuthChallengeRequest.

userNotFound information helps us when we have to generate dummy challenges for non-existing users so that users' presence is not disclosed.
kikuomax added a commit to kikuomax/aws-lambda-rust-runtime that referenced this issue Nov 4, 2023
@kikuomax
Add user_not_found to Create/Verify auth challenge events
8e1b8a1 
- Adds `user_not_found` field to:
    - `CognitoEventUserPoolsCreateAuthChallengeRequest`
    - `CognitoEventUserPoolsVerifyAuthChallengeRequest`
- Adds test cases where `user_not_found` becomes `true` for:
    - `CognitoEventUserPoolsDefineAuthChallengeRequest`
    - `CognitoEventUserPoolsCreateAuthChallengeRequest`
    - `CognitoEventUserPoolsVerifyAuthChallengeRequest`

issue awslabs#718
@kikuomax kikuomax mentioned this issue Nov 4, 2023
Merged
2 tasks
calavera pushed a commit that referenced this issue Nov 4, 2023
@kikuomax
Fix: Missing userNotFound field in "create/verify auth challenge" Cog…
c565173 
…nito user pool events (#719)

* Add user_not_found to Create/Verify auth challenge events

- Adds `user_not_found` field to:
    - `CognitoEventUserPoolsCreateAuthChallengeRequest`
    - `CognitoEventUserPoolsVerifyAuthChallengeRequest`
- Adds test cases where `user_not_found` becomes `true` for:
    - `CognitoEventUserPoolsDefineAuthChallengeRequest`
    - `CognitoEventUserPoolsCreateAuthChallengeRequest`
    - `CognitoEventUserPoolsVerifyAuthChallengeRequest`

issue #718

* Fix coding style with cargo fmt
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for the maintainers of this repository to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kikuomax