what???

TingDaoK · TingDaoK · commit fdb93fc443c4 · 2025-03-12T21:54:31.000Z
diff --git a/source/common.c b/source/common.c
@@ -46,15 +46,14 @@ PyObject *aws_py_thread_join_all_managed(PyObject *self, PyObject *args) {
         }
     }
     aws_thread_set_managed_join_timeout_ns(timeout_ns);
-
-    /* clang-format off */
-    Py_BEGIN_ALLOW_THREADS
+    // /* clang-format off */
+    // Py_BEGIN_ALLOW_THREADS
     /* Drop GIL to allow other threads callback into python to finish joining. */
     if (aws_thread_join_all_managed()) {
         Py_RETURN_FALSE;
     }
-    Py_END_ALLOW_THREADS
-    /* clang-format on */
+    // Py_END_ALLOW_THREADS
 
     Py_RETURN_TRUE;
+    /* clang-format on */
 }

Original file line number	Diff line number	Diff line change
`@@ -46,15 +46,14 @@ PyObject aws_py_thread_join_all_managed(PyObject self, PyObject *args) {`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`	`aws_thread_set_managed_join_timeout_ns(timeout_ns);`
`49`		`-`
`50`		`- /* clang-format off */`
`51`		`- Py_BEGIN_ALLOW_THREADS`
	`49`	`+ // /* clang-format off */`
	`50`	`+ // Py_BEGIN_ALLOW_THREADS`
`52`	`51`	`/* Drop GIL to allow other threads callback into python to finish joining. */`
`53`	`52`	`if (aws_thread_join_all_managed()) {`
`54`	`53`	`Py_RETURN_FALSE;`
`55`	`54`	`}`
`56`		`- Py_END_ALLOW_THREADS`
`57`		`- /* clang-format on */`
	`55`	`+ // Py_END_ALLOW_THREADS`
`58`	`56`
`59`	`57`	`Py_RETURN_TRUE;`
	`58`	`+ /* clang-format on */`
`60`	`59`	`}`