Adapt to aws_base64_compute_encoded_len() no longer adding 1 extra for null terminator.

graebm · graebm · commit ce35bed15b4f · 2025-03-17T09:06:28.000-07:00
See: awslabs/aws-c-common#1188
diff --git a/source/Types.cpp b/source/Types.cpp
@@ -110,12 +110,8 @@ namespace Aws
                 return {};
             }
 
-            // encoding appends a null terminator, and accounts for it in the encoded length,
-            // which makes the string 1 character too long
-            if (outputStr.back() == 0)
-            {
-                outputStr.pop_back();
-            }
+            AWS_ASSERT(outputStr.length() == tempBuf.len);
+
             return outputStr;
         }
     } // namespace Crt

Original file line number	Diff line number	Diff line change
`@@ -110,12 +110,8 @@ namespace Aws`
`110`	`110`	`return {};`
`111`	`111`	`}`
`112`	`112`
`113`		`- // encoding appends a null terminator, and accounts for it in the encoded length,`
`114`		`- // which makes the string 1 character too long`
`115`		`- if (outputStr.back() == 0)`
`116`		`- {`
`117`		`- outputStr.pop_back();`
`118`		`- }`
	`113`	`+ AWS_ASSERT(outputStr.length() == tempBuf.len);`
	`114`	`+`
`119`	`115`	`return outputStr;`
`120`	`116`	`}`
`121`	`117`	`} // namespace Crt`