Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeaseAssignmentManager excessive logging KCL 3.0.1 #1407

Closed
martinssonj opened this issue Nov 22, 2024 · 1 comment · Fixed by #1437
Closed

LeaseAssignmentManager excessive logging KCL 3.0.1 #1407

martinssonj opened this issue Nov 22, 2024 · 1 comment · Fixed by #1437

Comments

@martinssonj
Copy link

Hi.

With v3 of the KCL library LeaseAssignmentManager logs every 20 seconds. It looks like there are no problems so perhaps this should not be logged at all or DEBUG level instead

[2024-11-22 04:14:08.594] WARN  [lam-thread] s.a.k.c.a.LeaseAssignmentManager - List of workerIds with invalid entries : []
[2024-11-22 04:14:08.601] WARN  [lam-thread] s.a.k.c.a.LeaseAssignmentManager - Leases that failed deserialization : []
[2024-11-22 04:14:28.649] WARN  [lam-thread] s.a.k.c.a.LeaseAssignmentManager - List of workerIds with invalid entries : []
[2024-11-22 04:14:28.650] WARN  [lam-thread] s.a.k.c.a.LeaseAssignmentManager - Leases that failed deserialization : []
[2024-11-22 04:14:48.685] WARN  [lam-thread] s.a.k.c.a.LeaseAssignmentManager - List of workerIds with invalid entries : []
[2024-11-22 04:14:48.685] WARN  [lam-thread] s.a.k.c.a.LeaseAssignmentManager - Leases that failed deserialization : []
@ivanlkc
Copy link
Contributor

ivanlkc commented Feb 6, 2025

They shouldn't be logged when the list has zero members.

ivanlkc added a commit to ivanlkc/amazon-kinesis-client that referenced this issue Feb 6, 2025
@ivanlkc
Suppress LeaseAssignmentManager excessive WARN logs when there is no …
f1769ec 
…issue

This commit fixes awslabs#1407. The WARN level log statements should only be executed when a real problem had been detected.
@ivanlkc ivanlkc mentioned this issue Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@martinssonj @ivanlkc