Skip to content

Commit d611eea

Browse files
authored
ci(nix): Fix integ pq test in a devShell (#4576)
1 parent ff03b94 commit d611eea

File tree

4 files changed

+8
-15
lines changed

4 files changed

+8
-15
lines changed

codebuild/bin/s2n_setup_env.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,8 @@ fi
157157
export LIBFUZZER_ROOT=$LIBFUZZER_INSTALL_DIR
158158

159159
#check if the path contains test dep X, if not and X exists, add to path
160-
path_overrides="$PYTHON_INSTALL_DIR/bin
160+
path_overrides="$AWSLC_INSTALL_DIR/bin
161+
$PYTHON_INSTALL_DIR/bin
161162
$OPENSSL_1_1_1_INSTALL_DIR/bin
162163
$SAW_INSTALL_DIR/bin
163164
$Z3_INSTALL_DIR/bin

flake.lock

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flake.nix

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixos-22.11";
55
# TODO: https://github.com/aws/aws-lc/pull/830
6-
inputs.awslc.url = "github:dougch/aws-lc?ref=nix";
6+
inputs.awslc.url = "github:dougch/aws-lc?ref=nixv1.17.4";
77

88
outputs = { self, nix, nixpkgs, awslc, flake-utils }:
99
flake-utils.lib.eachDefaultSystem (system:
@@ -69,7 +69,7 @@
6969
cmake -S . -B./build \
7070
-DBUILD_SHARED_LIBS=ON \
7171
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
72-
-DS2N_NO_PQ=1
72+
-DS2N_NO_PQ=0
7373
''; # TODO: set when system like aarch64/mips,etc
7474

7575
buildPhase = ''

tests/integrationv2/test_pq_handshake.py

-8
Original file line numberDiff line numberDiff line change
@@ -283,9 +283,6 @@ def test_s2nc_to_awslc_pq_handshake(managed_process, s2n_client_policy, awslc_se
283283

284284
port = next(available_ports)
285285

286-
awslc_env_vars = dict()
287-
awslc_env_vars["PATH"] = os.path.abspath("../../test-deps/awslc/bin")
288-
289286
s2nc_client_options = ProviderOptions(
290287
mode=Provider.ClientMode,
291288
port=port,
@@ -297,7 +294,6 @@ def test_s2nc_to_awslc_pq_handshake(managed_process, s2n_client_policy, awslc_se
297294
mode=Provider.ServerMode,
298295
port=port,
299296
protocol=Protocols.TLS13,
300-
env_overrides=awslc_env_vars,
301297
curve=Curves.from_name(awslc_server_group.oqs_name))
302298

303299
awslc_server = managed_process(BoringSSL, awslc_server_options, timeout=5)
@@ -326,9 +322,6 @@ def test_s2nd_to_awslc_pq_handshake(managed_process, s2n_server_policy, awslc_cl
326322

327323
port = next(available_ports)
328324

329-
awslc_env_vars = dict()
330-
awslc_env_vars["PATH"] = os.path.abspath("../../test-deps/awslc/bin")
331-
332325
s2nd_server_options = ProviderOptions(
333326
mode=Provider.ServerMode,
334327
port=port,
@@ -340,7 +333,6 @@ def test_s2nd_to_awslc_pq_handshake(managed_process, s2n_server_policy, awslc_cl
340333
mode=Provider.ClientMode,
341334
port=port,
342335
protocol=Protocols.TLS13,
343-
env_overrides=awslc_env_vars,
344336
curve=Curves.from_name(awslc_client_group.oqs_name))
345337

346338
s2nd_server = managed_process(S2N, s2nd_server_options, timeout=5)

0 commit comments

Comments
 (0)