Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

begin_segment's name argument should be optional #87

Closed
moritonal opened this issue Mar 9, 2023 · 0 comments
Closed

begin_segment's name argument should be optional #87

moritonal opened this issue Mar 9, 2023 · 0 comments

Comments

@moritonal
Copy link

You already have a fallback defined in the method so name should be optional.

This would optimise XRay.recorder.begin_segment XRay.recorder.config.name into just XRay.recorder.begin_segment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moritonal