-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning: instance variable @metadata not initialized #84
Comments
Hi @etiennechabert - I think you're correct, I'm not exactly a Ruby expert but if you're interested in making a simple PR for this change we would definitely approve. |
@willarmiros thanks for the opportunity to contribute, let's continue the discussion in the PR I just created |
Closing after merge of: #86 |
@willarmiros would you be so kind to push for a new release to be created? I would like to update my gem and see the warnings be gone. Thanks in advance |
Hi @etiennechabert we have a release planned, but unfortunately I cannot provide ETAs. Feel free to watch the repo to get notified at the next release. |
Thanks, @willarmiros, I am sure you are already aware of this but still going to say it: more frequent releases would be greatly appreciated 🙏 Looking forward to the next one! 👋 |
Hello,
Version used: aws-xray-sdk-0.13.0
I am flooded by warnings such as:
Coming from this line: https://github.com/aws/aws-xray-sdk-ruby/blob/master/lib/aws-xray-sdk/model/entity.rb#L158
I have the feeling that this could be easily prevented if Instead of using directly,
@metadata
, we would be using themetadata
method ? https://github.com/aws/aws-xray-sdk-ruby/blob/master/lib/aws-xray-sdk/model/entity.rb#L64Sorry if I am totally missing something and this warning is actually because I am doing something wrong.
Best,
The text was updated successfully, but these errors were encountered: