Fix bug when joining from another device

update unit tests

Author: dylonChime

AmazonChimeSDK/AmazonChimeSDK/ingestion/IngestionConfigurationBuilder.swift

@@ -32,7 +32,7 @@ import Foundation
         return self
     }
 
-    public func build(disabled: Bool = true,
+    public func build(disabled: Bool = false,
                       ingestionUrl: String,
                       clientConiguration: EventClientConfiguration) -> IngestionConfiguration {
         return IngestionConfiguration(clientConfiguration: clientConiguration,

AmazonChimeSDK/AmazonChimeSDK/internal/audio/DefaultAudioClientObserver.swift

@@ -49,8 +49,8 @@ class DefaultAudioClientObserver: NSObject, AudioClientDelegate {
     }
 
     public func audioClientStateChanged(_ audioClientState: audio_client_state_t, status: audio_client_status_t) {
-        let newAudioState = Converters.AudioClientState.toSessionStateControllerAction(state: audioClientState)
         let newAudioStatus = Converters.AudioClientStatus.toMeetingSessionStatusCode(status: status)
+        let newAudioState = Converters.AudioClientState.toSessionStateControllerAction(state: audioClientState, status: newAudioStatus)
 
         if newAudioStatus == .unknown {
             logger.info(msg: "AudioClient State rawValue: \(audioClientState.rawValue) Unknown Status rawValue: \(status.rawValue)")
@@ -357,15 +357,15 @@ class DefaultAudioClientObserver: NSObject, AudioClientDelegate {
         switch currentAudioState {
         case .connecting,
              .finishConnecting:
-            if newAudioStatus == .audioServerHungup {
+            if Converters.AudioClientState.shouldCloseAndNotifyEndMeeting(status: newAudioStatus) {
                 handleAudioSessionEndedByServer(newAudioStatus: newAudioStatus)
             } // Else no-op, client initiated stops already handled in DefaultAudioClientController.stop()
             break
         case .reconnecting:
             notifyAudioClientObserver { (observer: AudioVideoObserver) in
                 observer.audioSessionDidCancelReconnect()
             }
-            if newAudioStatus == .audioServerHungup {
+            if Converters.AudioClientState.shouldCloseAndNotifyEndMeeting(status: newAudioStatus) {
                 handleAudioSessionEndedByServer(newAudioStatus: newAudioStatus)
             } // Else no-op, client initiated stops already handled in DefaultAudioClientController.stop()
         default:

AmazonChimeSDK/AmazonChimeSDK/internal/utils/Converters.swift

@@ -41,7 +41,10 @@ import Foundation
     }
 
     enum AudioClientState {
-        static func toSessionStateControllerAction(state: audio_client_state_t) -> SessionStateControllerAction {
+        static func toSessionStateControllerAction(state: audio_client_state_t, status: MeetingSessionStatusCode) -> SessionStateControllerAction {
+            if (shouldCloseAndNotifyEndMeeting(status: status)) {
+                return .finishDisconnecting
+            }
             switch state {
             case AUDIO_CLIENT_STATE_UNKNOWN:
                 return .unknown
@@ -55,16 +58,20 @@ import Foundation
                 return .reconnecting
             case AUDIO_CLIENT_STATE_DISCONNECTING:
                 return .disconnecting
-            case AUDIO_CLIENT_STATE_DISCONNECTED_NORMAL,
-                 AUDIO_CLIENT_STATE_SERVER_HUNGUP:
+            case AUDIO_CLIENT_STATE_DISCONNECTED_NORMAL:
                 return .finishDisconnecting
             case AUDIO_CLIENT_STATE_DISCONNECTED_ABNORMAL,
+                 AUDIO_CLIENT_STATE_SERVER_HUNGUP,
                  AUDIO_CLIENT_STATE_FAILED_TO_CONNECT:
                 return .fail
             default:
                 return .unknown
             }
         }
+        
+        static func shouldCloseAndNotifyEndMeeting(status: MeetingSessionStatusCode) -> Bool {
+            return status == MeetingSessionStatusCode.audioServerHungup || status == MeetingSessionStatusCode.audioJoinedFromAnotherDevice
+        }
     }
 
     enum Transcript {