Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Issue #311 and #310 #313

Closed
wants to merge 1 commit into from
Closed

Resolve Issue #311 and #310 #313

wants to merge 1 commit into from

Conversation

EashanKaushik
Copy link
Contributor

@EashanKaushik EashanKaushik commented Sep 27, 2024

Issue #, if available:
#310 and #311
Description of changes:

  1. Removed "Action": "Bedrock:InvokeMode" from lambda roles. Affected files:
    a. 01-create-agent-with-function-definition.ipynb
    b. 02-create-agent-with-api-schema.ipynb
    c. 03-create-agent-with-return-of-control.ipynb
    d. 06-prompt-and-session-attributes.ipynb
    e. 07-custom-prompt-and-lambda-parsers.ipynb
    f. 08-create-agent-with-guardrails/agent.py
    g. 10-create-agent-with-memory.ipynb

  2. Renamed Agent in agents-for-bedrock/features-examples/06-prompt-and-session-attributes/06-prompt-and-session-attributes.ipynb to hr-assistant-attributes to resolve conflicts.

  3. Removed error in CRM agent.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rsgrewal-aws rsgrewal-aws added the invalid This doesn't seem right label Oct 6, 2024
@rsgrewal-aws
Copy link
Contributor

Please re do this PR following the new layout and the process for creating the required file . We request all files to have a presence on the Cookbook / Recipes Website which is fronting this github repo now. Some of the mandatory sections of the notebook need to include

  • Overview.
  • What are we demonstrating .
  • What use case .
  • What will you learn.
  • What is the architectural pattern and why we select this. With a diagram
  • What are the libraries to install
  • What model did we choose and why this model
  • Every cell needs to have a markup

@EashanKaushik EashanKaushik closed this by deleting the head repository Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants