build release compilers for Windows (checkedc#495)

This fixes the build automation scripts for Windows to actually build release versions of clang.  We were relying on CMAKE_BUILD_TYPE, which is disregarded when cmake generates a build system for Visual Studio.  The fix is to pass the build type in as an additional parameter to the msbuild invocations instead.

This addresses issue checkedc#494, where the installed compiler required a debug version of the Windows CRT that isn't usually installed on Windows systems.

Testing:
- Build x86/x64 compiler installers.

Author: dtarditi

automation/Windows/build-package.bat

@@ -11,7 +11,7 @@ cd %LLVM_OBJ_DIR%
 if "%BUILD_PACKAGE%" == "No" (goto succeeded)
 
 echo.Building installation package for clang
-"%MSBUILD_BIN%" PACKAGE.vcxproj /v:%MSBUILD_VERBOSITY% /maxcpucount:%MSBUILD_CPU_COUNT% /p:CL_MPCount=%CL_CPU_COUNT%
+"%MSBUILD_BIN%" PACKAGE.vcxproj /p:Configuration=%BUILDCONFIGURATION% /v:%MSBUILD_VERBOSITY% /maxcpucount:%MSBUILD_CPU_COUNT% /p:CL_MPCount=%CL_CPU_COUNT%
  if ERRORLEVEL 1 (goto cmdfailed)
 
 rem Put the installer executable in its own subdirectory.  The VSTS build

automation/Windows/run-cmake.bat

@@ -10,7 +10,7 @@ if "%TEST_TARGET_ARCH%"=="AMD64" (
 
 if "%BUILD_PACKAGE%"=="Yes" (
   if "%BUILDCONFIGURATION%"=="Release" (
-   set EXTRA_FLAGS="DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON -DLLVM_USE_CRT_RELEASE=MT"
+   set EXTRA_FLAGS="-DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON -DLLVM_USE_CRT_RELEASE=MT"
   ) else (
     set EXTRA_FLAGS= 
   )
@@ -21,7 +21,9 @@ if "%BUILD_PACKAGE%"=="Yes" (
 set OLD_DIR=%CD%
 
 cd %LLVM_OBJ_DIR%
-cmake %CMAKE_GENERATOR% -T "host=x64" %EXTRA_FLAGS% -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON -DCMAKE_BUILD_TYPE=%BUILDCONFIGURATION% %BUILD_SOURCESDIRECTORY%\llvm
+rem  This generates a build system that supports multiple configurations.  Don't try setting CMAKE_BUILD_TYPE here 
+rem because it is ignored.
+cmake %CMAKE_GENERATOR% -T "host=x64" %EXTRA_FLAGS% -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON %BUILD_SOURCESDIRECTORY%\llvm
 if ERRORLEVEL 1 (goto cmdfailed)
 
 :succeeded

automation/Windows/test-clang.bat

@@ -12,17 +12,17 @@ cd %LLVM_OBJ_DIR%
 if "%SKIP_CHECKEDC_TESTS%"=="Yes" (
   rem
 ) else (
-  "%MSBUILD_BIN%" projects\checkedc-wrapper\check-checkedc.vcxproj /v:%MSBUILD_VERBOSITY% /maxcpucount:%MSBUILD_CPU_COUNT% /p:CL_MPCount=%CL_CPU_COUNT%
+  "%MSBUILD_BIN%" projects\checkedc-wrapper\check-checkedc.vcxproj /p:Configuration=%BUILDCONFIGURATION% /v:%MSBUILD_VERBOSITY% /maxcpucount:%MSBUILD_CPU_COUNT% /p:CL_MPCount=%CL_CPU_COUNT%
   if ERRORLEVEL 1 (goto cmdfailed)
 )
 
 if "%TEST_SUITE%"=="CheckedC" (
   rem
 ) else if "%TEST_SUITE%"=="CheckedC_clang" (
-  "%MSBUILD_BIN%" tools\clang\test\check-clang.vcxproj /v:%MSBUILD_VERBOSITY% /maxcpucount:%MSBUILD_CPU_COUNT% /p:CL_MPCount=%CL_CPU_COUNT%
+  "%MSBUILD_BIN%" tools\clang\test\check-clang.vcxproj /p:Configuration=%BUILDCONFIGURATION% /v:%MSBUILD_VERBOSITY% /maxcpucount:%MSBUILD_CPU_COUNT% /p:CL_MPCount=%CL_CPU_COUNT%
   if ERRORLEVEL 1 (goto cmdfailed)
 ) else if "%TEST_SUITE%"=="CheckedC_LLVM" (
-  "%MSBUILD_BIN%" check-all.vcxproj /v:%MSBUILD_VERBOSITY% /maxcpucount:%MSBUILD_CPU_COUNT% /p:CL_MPCount=%CL_CPU_COUNT%
+  "%MSBUILD_BIN%" check-all.vcxproj /p:Configuration=%BUILDCONFIGURATION% /v:%MSBUILD_VERBOSITY% /maxcpucount:%MSBUILD_CPU_COUNT% /p:CL_MPCount=%CL_CPU_COUNT%
   if ERRORLEVEL 1 (goto cmdfailed)
 )