Show relevant parts of the object/array for t.true/t.false assertion output

[vadimdemedes]

Note, this issue is related only to #1154.

Given this assertion:

t.true(arr[56]);

if the size of arr is (for example) 100, AVA will output the whole array without pointing to the specific item that caused an assertion error. We should show only the relevant parts of the array/object to identify the cause of an issue quicker. Plus, we really don't want to trash user's terminal.

---

IssueHunt Summary

Sponsors (Total: $60.00)

• issuehunt ($60.00)

Become a sponsor now!

Or submit a pull request to get the deposits!

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

[yatharthx]

@vadimdemedes thanks for pointing it out. I actually faced this thing last night and was thinking to open an issue.

[novemberborn]

My suggestion in #1204 is to show the type of arr but nothing else.

[leandrooriente]

Guys, do you have any update regarding this request?

I'm facing the same issue.
If I use t.is(resetBehaviour.calledOnce, false); it outputs this:

51:     wrapper.unmount();
   52:     t.is(resetBehaviour.calledOnce, false);
   53: });

  Difference:

  - true
  + false

  Test.is (src/common/components/App/App.test.js:52:7)
  processEmit [as emit] (node_modules/nyc/node_modules/signal-exit/index.js:155:32)
  processEmit [as emit] (node_modules/nyc/node_modules/signal-exit/index.js:155:32)

But if i use t.false(resetBehaviour.calledOnce) it returns this huge output:

51:     wrapper.unmount();
   52:     t.false(resetBehaviour.calledOnce);
   53: });

  Value is not `false`:

  true

  resetBehaviour.calledOnce
  => true

  resetBehaviour
  => Function proxy {
    args: [
      [],
    ],
    callCount: 1,
    callIds: [
      4,
    ],
    called: true,
    calledOnce: true,
    calledThrice: false,
    calledTwice: false,
    displayName: 'spy',
    errorsWithCallStack: [
      Error {
        message: '',
      },
    ],
    exceptions: [
      undefined,
    ],
    firstCall: {
      args: [],
      callId: 4,
      callback: undefined,
      errorWithCallStack: Error {
        message: '',
      },
      exception: undefined,
      lastArg: undefined,
      proxy: [Circular],
      returnValue: undefined,
      thisValue: {
        resetBehaviour: [Circular],
      },
    },
    id: 'spy#3',
    instantiateFake: Function create {},
    isSinonProxy: true,
    lastCall: {
      args: [],
      callId: 4,
      callback: undefined,
      errorWithCallStack: Error {
        message: '',
      },
      exception: undefined,
      lastArg: undefined,
      proxy: [Circular],
      returnValue: undefined,
      thisValue: {
        resetBehaviour: [Circular],
      },
    },
    notCalled: false,
    returnValues: [
      undefined,
    ],
    secondCall: null,
    thirdCall: null,
    thisValues: [
      {
        resetBehaviour: [Circular],
      },
    ],
    toString: Function toString {},
  }

  Test.t [as fn] (src/common/components/App/App.test.js:52:5)
  processEmit [as emit] (node_modules/nyc/node_modules/signal-exit/index.js:155:32)
  processEmit [as emit] (node_modules/nyc/node_modules/signal-exit/index.js:155:32)

I'm using sinon spies and the log output is completely uselesss in this case.

[IssueHuntBot]

@issuehunt has funded $60.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[novemberborn]

FWIW, AVA no longer prints output like this, though it's supported through @ava/babel. I'm going to close this issue since I don't think we'll make any progress on this one way or the other.