Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to RawString through automerge-repo? #326

Open
joshuahhh opened this issue Mar 24, 2024 · 1 comment
Open

Access to RawString through automerge-repo? #326

joshuahhh opened this issue Mar 24, 2024 · 1 comment

Comments

@joshuahhh
Copy link
Contributor

My code, which is primarily automerge-repo-based, accessed RawString through a '@automerge/automerge/next' import. At one point, I noticed that I didn't have '@automerge/automerge' in my package.json, which I reflexively consider bad practice, so I added it. This actually broke my code, I think because automerge-repo used a different version of automerge. (This was the root cause of automerge/automerge#891, fwiw.)

I want to flag this as a potential issue. My guess is that the best approach would be for automerge-repo to be a "one stop shop" – just import it and you'll get everything you need in a nice consistent bundle, including access to RawString. If it's better to access RawString through a separate automerge import, I wonder what approach would make sure that versions are in sync, and/or provide helpful error messages if they get out of sync.

(Thanks!)

@pvh
Copy link
Member

pvh commented Apr 9, 2024

I agree! I'd like to go through all of Automerge-Core and make sure we export any types and functions you might need as well as generally cleaning up the API. I think that might be a good small project to make a point release out of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants