Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recreated timed out tasks disqualifies workers #34

Open
yechs opened this issue Jun 22, 2022 · 0 comments
Open

Recreated timed out tasks disqualifies workers #34

yechs opened this issue Jun 22, 2022 · 0 comments
Labels
bug

Comments

@yechs
Copy link
Collaborator

yechs commented Jun 22, 2022

Screen Shot 2022-06-22 at 11 52 55 AM

This is the same tasks as created in #33
@yechs yechs added the bug label Jun 22, 2022
yechs added a commit that referenced this issue Jun 24, 2022
@yechs
fix: Partially fix #34
3fa02f2 
Now we have correct qualification requirements
However, each batch (round) checks for different QualificationTypeId's. Will look at this bug later

Caveat: I hard-coded a 0 into memo storage to bypass a get of null value error. We might want to delete it from the memo data structure later, because we no longer check for equality with batch_no in qualification requirement.
yechs added a commit that referenced this issue Jun 28, 2022
@yechs
fix: Refactor disqualification logic
dac1cc5 
Now qualification requirement are based on "Qualification Type ID xxxx has not been granted". Further, the same requirement is equally applied to all batches/rounds of the same question.

As a result, user no longer need to manually request for qualifications in later batches (since they were never granted disqualifications)

Fixes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yechs