Skip to content

Commit 6fa5b4a

Browse files
Rename delete_user_authenticator to delete_authenticator for consistency (#29)
* Rename delete_user_authenticator to delete_authenticator for consistency * Bump major version
1 parent 95efce7 commit 6fa5b4a

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

Gemfile.lock

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: .
33
specs:
4-
authsignal-ruby (3.0.1)
4+
authsignal-ruby (4.0.0)
55
faraday (>= 2)
66
faraday-retry (~> 2.2)
77

lib/authsignal.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ def enroll_verified_authenticator(user_id:, authenticator:)
5555
handle_response(response)
5656
end
5757

58-
def delete_user_authenticator(user_id:, user_authenticator_id: )
59-
response = Client.new.delete_user_authenticator(user_id: user_id, user_authenticator_id: user_authenticator_id)
58+
def delete_authenticator(user_id:, user_authenticator_id: )
59+
response = Client.new.delete_authenticator(user_id: user_id, user_authenticator_id: user_authenticator_id)
6060

6161
handle_response(response)
6262
end

lib/authsignal/client.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def enroll_verified_authenticator(user_id, authenticator)
8484
make_request(:post, "users/#{url_encode(user_id)}/authenticators", body: authenticator)
8585
end
8686

87-
def delete_user_authenticator(user_id:, user_authenticator_id:)
87+
def delete_authenticator(user_id:, user_authenticator_id:)
8888
make_request(:delete, "users/#{url_encode(user_id)}/authenticators/#{url_encode(user_authenticator_id)}")
8989
end
9090

lib/authsignal/version.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# frozen_string_literal: true
22

33
module Authsignal
4-
VERSION = "3.0.1"
4+
VERSION = "4.0.0"
55
end

spec/authsignal/authsignal_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -119,15 +119,15 @@
119119
end
120120
end
121121

122-
describe ".delete_user_authenticator" do
122+
describe ".delete_authenticator" do
123123
it 'succeeds' do
124124
stub_request(:delete, "#{base_uri}/users/1/authenticators/9b2cfd40-7df2-4658-852d-a0c3456e5a2e")
125125
.with(basic_auth: ['secret', ''])
126126
.to_return(body: {success: true}.to_json,
127127
status: 200,
128128
headers: {'Content-Type' => 'application/json'})
129129

130-
response = described_class.delete_user_authenticator(user_id: 1, user_authenticator_id: '9b2cfd40-7df2-4658-852d-a0c3456e5a2e')
130+
response = described_class.delete_authenticator(user_id: 1, user_authenticator_id: '9b2cfd40-7df2-4658-852d-a0c3456e5a2e')
131131

132132
expect(response[:success]).to eq(true)
133133
expect(response[:success?]).to be true

0 commit comments

Comments
 (0)