Skip to content

Commit 19be0c1

Browse files
committedMar 9, 2024
Fix use-render
1 parent 3bd17c9 commit 19be0c1

File tree

5 files changed

+11
-18
lines changed

5 files changed

+11
-18
lines changed
 

‎packages/use-child-nodes/test/use-render.test.js

-15
This file was deleted.

‎packages/use-render/example/index.tsx

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ import { useRender } from "../src";
44
const MyComponent = c(
55
({ name, checked }) => {
66
useRender(<input type="checkbox" name={name} checked={checked} />);
7+
useRender(() => (
8+
<input type="checkbox" name={name} checked={checked} />
9+
));
710

811
return (
912
<host shadowDom>

‎packages/use-render/src/index.tsx

+6-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,16 @@ const fillHost = (vnode?: any) =>
1010
* Generate a second render, this render escapes the current
1111
* one and is useful for collaborative work between LightDOM and shadowDOM
1212
*/
13-
export function useRender(callback: () => any, args?: any[]) {
13+
export function useRender(view: any, args?: any[]) {
1414
const host = useHost();
1515

1616
host.id = host.id || Symbol();
1717

1818
useInsertionEffect(() => {
19-
render(fillHost(callback), host.current, host.id);
19+
render(
20+
fillHost(typeof view === "function" ? view() : view),
21+
host.current,
22+
host.id,
23+
);
2024
}, args);
2125
}

‎packages/use-render/test/example.tsx

-1
This file was deleted.

‎packages/use-render/test/use-render.test.js

+2
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,7 @@ it("use-render", () => {
1111
useRender(() => html`<button />`);
1212
});
1313

14+
hooks.cleanEffects()()();
15+
1416
expect(container.querySelector("button")).to.not.equal(null);
1517
});

0 commit comments

Comments
 (0)
Please sign in to comment.