Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm whether ePSF residual mapping differing from Anderson & King (2000) is correct with regards to how far samplings are drawn per grid point for sigma clipping #994

Open
Onoddil opened this issue Nov 20, 2019 · 0 comments

Comments

@Onoddil
Copy link
Contributor

Onoddil commented Nov 20, 2019

At present, in EPSFBuilder, when calculating star residual samplings and sigma clipping multiple samplings to find the robust residual for a given grid point -- used to update the interpolation spline points with more accurate PSF samples -- the current implementation uses a nearest neighbour fitting (_py2intround), but the algorithm as detailed in Anderson & King (2000) uses all star samplings within an oversampled grid spacing (i.e., a quarter of a pixel for oversampling=4) to compute the sigma clipped average residual value. Note that nearest neighbour fitting is essentially all data points within half a grid spacing, instead of a whole grid spacing, reducing the number of samples used to compute each grid point residual by a factor 4, and removing some implicit data smoothing without the "rolling average".

There were some other, undocumented changes to EPSFBuilder relative to those in the AK00 paper, so is this another case of a fix made for unknown but valid reasons, or should this be changed to align with the algorithm's intent and swap to pulling samplings from within a whole grid spacing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants