Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbers passed in first argument to bases.fromAlplabet cause a return value of 0 #9

Open
pmaxhogan opened this issue May 1, 2017 · 1 comment
Open

Numbers passed in first argument to bases.fromAlplabet cause a return value of 0 #9

pmaxhogan opened this issue May 1, 2017 · 1 comment

Comments

@pmaxhogan
Copy link

When you call

bases.fromAlphabet(127, '0123456789abcdef');

returns 0, but

bases.fromAlphabet("127", '0123456789abcdef')

returns 295 (correct).

The fix is to call str = str.toString(); in the first line of bases.fromAlplabet.
@pmaxhogan pmaxhogan mentioned this issue May 2, 2017
Open
@pmaxhogan
Copy link
Author

Fixed in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmaxhogan