Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Completions in 0.16.1 still show removed hyphenated commands. #1908

Closed
mike-mike-mike-mike-mike opened this issue Feb 6, 2025 · 3 comments · Fixed by #1912
Closed
Labels

Comments

@mike-mike-mike-mike-mike

Describe the Bug

This section of the migration documentation notes that hyphenated commands were replaced with non-hyphenated versions. Additionally, this commit updates the help text accordingly.

But the completions that are generated (at least in zsh) still show the old, hyphenated versions (see image). I've even uninstalled and reinstalled asdf completely.

Image

Image

Steps to Reproduce

  1. Install or upgrade to asdf 0.16.1
  2. type asdf into zsh and hit TAB

Expected Behaviour

Completion options should match the actual commands

Actual Behaviour

Completions show commands that no longer exist

Environment

OS:
Darwin Mac 24.3.0 Darwin Kernel Version 24.3.0: Thu Jan  2 20:24:22 PST 2025; root:xnu-11215.81.4~3/RELEASE_ARM64_T6041 arm64

SHELL:
zsh 5.9 (arm64-apple-darwin24.0)

BASH VERSION:
3.2.57(1)-release

ASDF VERSION:
0.16.1

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=/Users/michael.lambert/.asdf
ASDF_CONFIG_FILE=/Users/michael.lambert/.asdfrc

ASDF INSTALLED PLUGINS:
nodejs    https://github.com/asdf-vm/asdf-nodejs.git 93bd217ba74f05080eebb7d8e1c146a385b01d7f
ruby      https://github.com/asdf-vm/asdf-ruby.git   98e32b9c38e146b164d651c96ccb6d5fa4c3af90
yarn      https://github.com/twuni/asdf-yarn.git     376c5407ef22c82fa56e4bd9f6a9108354063acb

asdf plugins affected (if relevant)

No response

@maple3142
Copy link

Same issue on zsh, and newer sub commands like set is not available too.

@epiccoleman
Copy link

I've got the same issue. The version of the completions file I'm using is the one included in the Homebrew package at /opt/homebrew/share/zsh/site-functions.

@danielemegna
Copy link

danielemegna commented Feb 7, 2025

Also without zsh and fish (normal bash setup) the auto-completion is suggesting old commands and is not working with new commands. I still use this in my .bashrc to configure it: . <(asdf completion bash).

$ asdf <tab>
current          info             list             plugin-add       plugin-remove    shell            update           
global           install          list-all         plugin-list      plugin-update    shim-versions    where            
help             latest           local            plugin-list-all  reshim           uninstall        which            
$ asdf set <tab>
current          info             list             plugin-add       plugin-remove    shell            update           
global           install          list-all         plugin-list      plugin-update    shim-versions    where            
help             latest           local            plugin-list-all  reshim           uninstall        which            
$ asdf global <tab>
Display all 208 possibilities? (y or n)
$ asdf global nodejs <tab>
18.20.3  20.10.0  8.9.3    system

and if i execute a suggested (old) command it is not recognized of course

$ asdf global nodejs 20.10.0
version: 0.16.1-arch
...
...
PLUGIN nodejs
  asdf nodejs nodebuild.bash
  asdf nodejs resolve.bash
  asdf nodejs update-nodebuild.bash

"Late but latest"
-- Rajinikanth

Maybe a "configure autocomplete" section should be added in this guide if some change is needed: https://asdf-vm.com/guide/upgrading-to-v0-16.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants