bug: [0.16] removing awscli shims

[hal9000jw]

Describe the Bug

After upgrading to the 0.16 release, I tested installing a newer terraform version. I discovered that the aws and aws_completer shims had been removed. Attempting to uninstall and reinstall the awscli shim had no effect.

Steps to Reproduce

1. Perform the 0.16 upgrade steps as documented
2. Install a new terraform version: asdf install terraform <version>
3. Discovered that the aws and aws_completer shims had been removed
4. Reinstalled the awscli version: asdf uninstall aswcli <version> and asdf uninstall aswcli <version>
5. Discovered that the shims were not recreated

Expected Behaviour

The awscli shims should be maintained after the 0.16 upgrade.

Actual Behaviour

The awscli shims are removed and the aws command is not available from the command line.

Environment

$ asdf info
OS:
Linux sirius 5.15.0-117-generic #127~20.04.1-Ubuntu SMP Thu Jul 11 15:36:12 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

SHELL:
GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

BASH VERSION:
5.0.17(1)-release

ASDF VERSION:
v0.16.0

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=/home/<removed>/.asdf
ASDF_CONFIG_FILE=/home/<removed>/.asdfrc

ASDF INSTALLED PLUGINS:
awscli         https://github.com/MetricMike/asdf-awscli.git         c645552054ad8a8bf3521cc37e7f44ea9dba1def
oci            https://github.com/yasn77/asdf-oci.git                4b228f4b07732ee305ef0711f101d7dc082c7874
packer         https://github.com/Banno/asdf-hashicorp.git           3122c040b989cde088ec7710d346d30af7f58e3f
pre-commit     https://github.com/jonathanmorley/asdf-pre-commit.git 26bfc420d6009f700514d6218cc28947d1c3aad9
ruby           https://github.com/asdf-vm/asdf-ruby.git              3941f47d06e2c0fd9a99a6cc2ef5419ea0313549
terraform      https://github.com/Banno/asdf-hashicorp.git           3122c040b989cde088ec7710d346d30af7f58e3f
terraform-docs https://github.com/looztra/asdf-terraform-docs.git    3ec72e5aa1b7ef19678579e41f309f9343868c9f
tflint         https://github.com/skyzyx/asdf-tflint.git             37e7eb9b758bbe77319ee312fc3764ef9d0944aa

asdf plugins affected (if relevant)

awscli

[Stratus3D]

Hi @hal9000jw , can you confirm that the asdf shims directory is on your path? Typically this directory is at ~/.asdf/shims unless you've customized it.

Are all the other shims still available? If this issue is only affecting awscli it's probably an issue with that plugin rather than asdf core.

[hal9000jw]

@Stratus3D Yes sir on both accounts! Reverting back to asdf 0.15 and reinstalling awscli resolved the issue.

[Stratus3D]

Being that we have two reports of issues with the awscli plugin, and no reports for other plugins, I think there is probably something that isn't implemented properly in the awscli plugin. I'll leave this issue open until I have time to investigate though.