Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subcommand which will output which version is currently LTS #339

Closed
onnimonni opened this issue Feb 19, 2023 · 1 comment · Fixed by #353
Closed

Add subcommand which will output which version is currently LTS #339

onnimonni opened this issue Feb 19, 2023 · 1 comment · Fixed by #353

Comments

@onnimonni
Copy link
Contributor

Hey!

I saw LTS versions have been discussed already in #308 and there seems to be longer workaround in asdf-vm/asdf#1024.

But I see that this plugin currently adds few subcommands to asdf:

$ asdf
...
PLUGIN nodejs
  asdf nodejs nodebuild
  asdf nodejs update nodebuild

Could we add a subcommand which would resolve the current lts version into version number?

I'm running a daily github action that will create pull request to my .tool-versions file to newer version whenever that is available.

Now without this alias I need to waste compute resources to install that nodejs into that github action before I can actually see what the version is.

If we would have a alias which would resolve the lts to the latest one then we wouldn't need to do that and the github action would be much faster 👍
@augustobmoura
Copy link
Member

Hi @onnimonni 👋

That's a really good idea! I thought about it when I was implementing lts aliases but because it was not urgent I didn't finish it.

I'm having little time to do it right now, but we are open to contributions if you want to have a stab at it.

I think what we need to do is create a command extension script file that calls for print_index_tab and grep for the lts passed as argument, similar to how we do it on install. I can help with any questions you have

@augustobmoura augustobmoura mentioned this issue May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add resolve command for resolving legacy version queries augustobmoura/asdf-nodejs
2 participants
@onnimonni @augustobmoura