Skip to content

Commit ac3221d

Browse files
committed
Use gh markdown highlights of warnings, tips and notes
1 parent 744f08f commit ac3221d

15 files changed

+334
-147
lines changed

LICENSES/README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ Since most source files in Kodi are `GPL-2.0-or-later` licensed, the typical cop
4343
*/
4444
```
4545

46-
**NOTE:** Kodi is developed and maintained by Kodi Team members and the open-source community. We thank all of our **[contributors](https://github.com/xbmc/xbmc/graphs/contributors)**! **For the detailed history of contributions** of a given file, use `git blame <filename>` to see line-by-line credits or `git log --follow <filename>` to see the changelog across renames, rewrites and code shuffle.
46+
> [!NOTE]
47+
> Kodi is developed and maintained by Kodi Team members and the open-source community. We thank all of our **[contributors](https://github.com/xbmc/xbmc/graphs/contributors)**! **For the detailed history of contributions** of a given file, use `git blame <filename>` to see line-by-line credits or `git log --follow <filename>` to see the changelog across renames, rewrites and code shuffle.
4748
4849
### License Files
4950
All SPDX license identifiers must have a corresponding file in the **LICENSES** subdirectory. This is required to allow tool verification (e.g. **[ScanCode toolkit](https://github.com/nexB/scancode-toolkit)**) and to have the licenses ready to read and extract right from the source, which is recommended by various FOSS organizations, e.g. the **[FSFE REUSE Initiative](https://reuse.software/)**.

docs/CODE_GUIDELINES.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -595,7 +595,9 @@ Prefix global variables with `g_`
595595
```cpp
596596
int g_globalVariableA;
597597
```
598-
**WARNING:** Avoid use of globals as far as reasonably possible. We generally do not want to introduce new global variables.
598+
599+
> [!WARNING]
600+
> Avoid use of globals as far as reasonably possible. We generally do not want to introduce new global variables.
599601
600602
**[back to top](#table-of-contents)**
601603

docs/GIT-FU.md

+14-6
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,14 @@ git clone -b Krypton https://github.com/xbmc/xbmc kodi
8686

8787
Several different strategies are used to draw your attention to certain pieces of information. In order of how critical the information is, these items are marked as a note, tip, or warning. For example:
8888

89-
**NOTE:** Linux is user friendly... It's just very particular about who its friends are.
90-
**TIP:** Algorithm is what developers call code they do not want to explain.
91-
**WARNING:** Developers don't change light bulbs. It's a hardware problem.
89+
> [!NOTE]
90+
> Linux is user friendly... It's just very particular about who its friends are.
91+
92+
> [!TIP]
93+
> Algorithm is what developers call code they do not want to explain.
94+
95+
> [!WARNING]
96+
> Developers don't change light bulbs. It's a hardware problem.
9297
9398
**[back to top](#table-of-contents)** | **[back to section top](#2-document-conventions)**
9499

@@ -121,7 +126,8 @@ cd kodi // change to the newly
121126
git remote add upstream https://github.com/xbmc/xbmc.git // assign Kodi's main repo to a remote
122127
```
123128

124-
**TIP:** Windows users should use `cd %userprofile%` instead.
129+
> [!TIP]
130+
> Windows users should use `cd %userprofile%` instead.
125131
126132
From this point forward, every command shown assumes you're inside `$HOME/kodi` or `%userprofile%\kodi` if you're a Windows user. To get there, issue:
127133
```
@@ -197,7 +203,8 @@ Delete remote branch:
197203
git push origin -d <feature-branch>
198204
```
199205

200-
**WARNING:** Be careful deleting branches. Make sure you don't need them anymore.
206+
> [!WARNING]
207+
> Be careful deleting branches. Make sure you don't need them anymore.
201208
202209
### 5.8. Rebase branch
203210
```
@@ -236,7 +243,8 @@ git checkout <feature-branch> // switch to feature branch
236243
git push origin // push updated feature branch to your personal remote repo
237244
```
238245

239-
**WARNING:** Be **very careful** updating to and from origin. It can cause loss of work, specially if you work on more than one machine. Make sure your remote origin repo **always** holds the most up-to-date version of your code. **No, seriously**. Make a mental rule: *remote origin repo always holds the most up-to-date version of my code!* and **stick to it!** It's almost always possible to recover lost work with `git` but it's hard and unnecessary work if you follow some simple rules.
246+
> [!WARNING]
247+
> Be **very careful** updating to and from origin. It can cause loss of work, specially if you work on more than one machine. Make sure your remote origin repo **always** holds the most up-to-date version of your code. **No, seriously**. Make a mental rule: *remote origin repo always holds the most up-to-date version of my code!* and **stick to it!** It's almost always possible to recover lost work with `git` but it's hard and unnecessary work if you follow some simple rules.
240248
241249
**[back to top](#table-of-contents)** | **[back to section top](#6-syncing-branches)**
242250

docs/README.Android.md

+27-12
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,14 @@ git clone -b Krypton https://github.com/xbmc/xbmc kodi
4848

4949
Several different strategies are used to draw your attention to certain pieces of information. In order of how critical the information is, these items are marked as a note, tip, or warning. For example:
5050

51-
**NOTE:** Linux is user friendly... It's just very particular about who its friends are.
52-
**TIP:** Algorithm is what developers call code they do not want to explain.
53-
**WARNING:** Developers don't change light bulbs. It's a hardware problem.
51+
> [!NOTE]
52+
> Linux is user friendly... It's just very particular about who its friends are.
53+
54+
> [!TIP]
55+
> Algorithm is what developers call code they do not want to explain.
56+
57+
> [!WARNING]
58+
> Developers don't change light bulbs. It's a hardware problem.
5459
5560
**[back to top](#table-of-contents)** | **[back to section top](#1-document-conventions)**
5661

@@ -59,9 +64,11 @@ Install build dependencies needed to cross-compile Kodi for Android:
5964
```
6065
sudo apt install autoconf bison build-essential curl default-jdk flex gawk git gperf lib32stdc++6 lib32z1 lib32z1-dev libcurl4-openssl-dev unzip zip zlib1g-dev
6166
```
62-
**NOTE:** If you're running a 32bit Debian/Ubuntu distribution, remove `lib32stdc++6 lib32z1 lib32z1-dev` from the command.
63-
**NOTE:** Gradle 7.0.2+ requires Jave Runtime 11+. Check java version by running `java --version`. If version is < 11, set JAVA_HOME to java 11+ home directory._
67+
> [!NOTE]
68+
> If you're running a 32bit Debian/Ubuntu distribution, remove `lib32stdc++6 lib32z1 lib32z1-dev` from the command.
6469
70+
> [!NOTE]
71+
> Gradle 7.0.2+ requires Jave Runtime 11+. Check java version by running `java --version`. If version is < 11, set JAVA_HOME to java 11+ home directory._
6572
6673
**[back to top](#table-of-contents)**
6774

@@ -82,7 +89,8 @@ Extract Android SDK Command line tools:
8289
unzip $HOME/Downloads/commandlinetools-linux-6200805_latest.zip -d $HOME/android-tools/android-sdk-linux/
8390
```
8491

85-
**NOTE:** Since we're using the latest SDK Command line tools available, filename can change over time. Adapt the `unzip` command accordingly.
92+
> [!NOTE]
93+
> Since we're using the latest SDK Command line tools available, filename can change over time. Adapt the `unzip` command accordingly.
8694
8795
### 3.2. Configure Android SDK
8896
Before Android SDK can be used, you need to accept the licenses and configure it:
@@ -122,7 +130,8 @@ cd $HOME/kodi/tools/depends
122130
./bootstrap
123131
```
124132

125-
**TIP:** Look for comments starting with `Or ...` and only execute the command(s) you need.
133+
> [!TIP]
134+
> Look for comments starting with `Or ...` and only execute the command(s) you need.
126135
127136
Configure build for aarch64:
128137
```
@@ -144,16 +153,19 @@ Or configure build for x86_64:
144153
./configure --with-tarballs=$HOME/android-tools/xbmc-tarballs --host=x86_64-linux-android --with-sdk-path=$HOME/android-tools/android-sdk-linux --with-ndk-path=$HOME/android-tools/android-sdk-linux/ndk/21.4.7075529 --prefix=$HOME/android-tools/xbmc-depends
145154
```
146155

147-
> **Note:** Android x86 and x86_64 are not maintained and are not 100% sure that everything works correctly!
156+
> [!NOTE]
157+
> Android x86 and x86_64 are not maintained and are not 100% sure that everything works correctly!
148158
149159
Build tools and dependencies:
150160
```
151161
make -j$(getconf _NPROCESSORS_ONLN)
152162
```
153163

154-
**TIP:** By adding `-j<number>` to the make command, you can choose how many concurrent jobs will be used and expedite the build process. It is recommended to use `-j$(getconf _NPROCESSORS_ONLN)` to compile on all available processor cores. The build machine can also be configured to do this automatically by adding `export MAKEFLAGS="-j$(getconf _NPROCESSORS_ONLN)"` to your shell config (e.g. `~/.bashrc`).
164+
> [!TIP]
165+
> By adding `-j<number>` to the make command, you can choose how many concurrent jobs will be used and expedite the build process. It is recommended to use `-j$(getconf _NPROCESSORS_ONLN)` to compile on all available processor cores. The build machine can also be configured to do this automatically by adding `export MAKEFLAGS="-j$(getconf _NPROCESSORS_ONLN)"` to your shell config (e.g. `~/.bashrc`).
155166
156-
**WARNING:** Look for the `Dependencies built successfully.` success message. If in doubt run a single threaded `make` command until the message appears. If the single make fails, clean the specific library by issuing `make -C target/<name_of_failed_lib> distclean` and run `make`again.
167+
> [!WARNING]
168+
> Look for the `Dependencies built successfully.` success message. If in doubt run a single threaded `make` command until the message appears. If the single make fails, clean the specific library by issuing `make -C target/<name_of_failed_lib> distclean` and run `make`again.
157169
158170
### 5.1. Advanced Configure Options
159171

@@ -280,7 +292,9 @@ cd $HOME/kodi
280292
make -C tools/depends/target/cmakebuildsys
281293
```
282294

283-
**TIP:** BUILD_DIR can be provided as an argument to cmakebuildsys. This allows you to provide an alternate build location. Change all paths onwards as required if BUILD_DIR option used.
295+
> [!TIP]
296+
> BUILD_DIR can be provided as an argument to cmakebuildsys. This allows you to provide an alternate build location. Change all paths onwards as required if BUILD_DIR option used.
297+
284298
```
285299
mkdir $HOME/kodi-build
286300
make -C tools/depends/target/cmakebuildsys BUILD_DIR=$HOME/kodi-build
@@ -358,7 +372,8 @@ Enable CheckJNI (**before** starting the Kodi):
358372
adb shell setprop debug.checkjni 1
359373
```
360374

361-
**NOTE:** These commands assume that current directory is `$HOME/kodi-build/tools/android/packaging` and that the proper SDK/NDK paths are set.
375+
> [!NOTE]
376+
> These commands assume that current directory is `$HOME/kodi-build/tools/android/packaging` and that the proper SDK/NDK paths are set.
362377
363378
GDB can be used to debug, though the support is rather primitive. Rather than using `gdb` directly, you will need to use `ndk-gdb` which wraps it. You can use the `-p/--project` switches or instead you will need to `cd` to `$HOME/kodi-build/tools/android/packaging/xbmc` and execute it from there.
364379
```

docs/README.Fedora.md

+16-7
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,14 @@ git clone -b Krypton https://github.com/xbmc/xbmc kodi
3838

3939
Several different strategies are used to draw your attention to certain pieces of information. In order of how critical the information is, these items are marked as a note, tip, or warning. For example:
4040

41-
**NOTE:** Linux is user friendly... It's just very particular about who its friends are.
42-
**TIP:** Algorithm is what developers call code they do not want to explain.
43-
**WARNING:** Developers don't change light bulbs. It's a hardware problem.
41+
> [!NOTE]
42+
> Linux is user friendly... It's just very particular about who its friends are.
43+
44+
> [!TIP]
45+
> Algorithm is what developers call code they do not want to explain.
46+
47+
> [!WARNING]
48+
> Developers don't change light bulbs. It's a hardware problem.
4449
4550
**[back to top](#table-of-contents)** | **[back to section top](#1-document-conventions)**
4651

@@ -61,14 +66,16 @@ git clone https://github.com/xbmc/xbmc kodi
6166
## 3. Install the required packages
6267
If you get a `package not found` type of message with the below command, remove the offending package(s) from the install list and reissue the command. Take a note of the missing dependencies and, after a successful step completion, **[build the missing dependencies manually](README.Linux.md#31-build-missing-dependencies)**.
6368

64-
**NOTE:** Kodi requires a compiler with C++17 support, i.e. gcc >= 7 or clang >= 5
69+
> [!NOTE]
70+
> Kodi requires a compiler with C++17 support, i.e. gcc >= 7 or clang >= 5
6571
6672
Install build dependencies:
6773
```
6874
sudo dnf install alsa-lib-devel autoconf automake avahi-compat-libdns_sd-devel avahi-devel bluez-libs-devel bzip2-devel cmake curl dbus-devel flatbuffers flatbuffers-devel fmt-devel fontconfig-devel freetype-devel fribidi-devel fstrcmp-devel gawk gcc gcc-c++ gettext gettext-devel giflib-devel gperf gtest-devel java-11-openjdk-headless jre lcms2-devel libao-devel libass-devel libbluray-devel libcap-devel libcdio-devel libcec-devel libcurl-devel libidn2-devel libjpeg-turbo-devel libmicrohttpd-devel libmpc-devel libnfs-devel libplist-devel libpng12-devel libsmbclient-devel libtool libtool-ltdl-devel libudev-devel libunistring libunistring-devel libusb-devel libuuid-devel libva-devel libvdpau-devel libxkbcommon-devel libxml2-devel libXmu-devel libXrandr-devel libxslt-devel libXt-devel lirc-devel lzo-devel make mariadb-devel mesa-libEGL-devel mesa-libGL-devel mesa-libGLU-devel mesa-libGLw-devel mesa-libOSMesa-devel nasm openssl-devel openssl-libs patch pcre-devel pulseaudio-libs-devel python3-devel python3-pillow rapidjson-devel shairplay-devel spdlog-devel sqlite-devel swig taglib-devel tinyxml-devel tinyxml2-devel trousers-devel uuid-devel zlib-devel
6975
```
7076

71-
**WARNING:** Make sure you copy paste the entire line or you might receive an error or miss a few dependencies.
77+
> [!WARNING]
78+
> Make sure you copy paste the entire line or you might receive an error or miss a few dependencies.
7279
7380
Building for Wayland requires some extra packages:
7481
```
@@ -85,14 +92,16 @@ Optional packages that you might want to install for extra functionality (genera
8592
sudo dnf install doxygen mariadb-devel
8693
```
8794

88-
**NOTE:** For developers and anyone else who builds frequently it is recommended to install `ccache` to expedite subsequent builds of Kodi.
95+
> [!NOTE]
96+
> For developers and anyone else who builds frequently it is recommended to install `ccache` to expedite subsequent builds of Kodi.
8997
9098
You can install it with:
9199
```
92100
sudo dnf install ccache
93101
```
94102

95-
**TIP:** If you have multiple computers at home, `distcc` will distribute build workloads of C and C++ code across several machines on a network. Team Kodi may not be willing to give support if problems arise using such a build configuration.
103+
> [!TIP]
104+
> If you have multiple computers at home, `distcc` will distribute build workloads of C and C++ code across several machines on a network. Team Kodi may not be willing to give support if problems arise using such a build configuration.
96105
97106
You can install it with:
98107
```

0 commit comments

Comments
 (0)