Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new expr-lang builtins instead of pkg functions #3506

Closed
crenshaw-dev opened this issue Mar 6, 2025 · 0 comments · Fixed by #3507
Closed

Use new expr-lang builtins instead of pkg functions #3506

crenshaw-dev opened this issue Mar 6, 2025 · 0 comments · Fixed by #3507
Labels
enhancement New feature or request

Comments

@crenshaw-dev
Copy link
Member

Describe the solution you'd like

expr-lang has included int, float, and string functions since 1.14.0. Argo Workflows currently uses expr 1.16.9. Instead of using those functions as implemented in argoproj/pkg, we should use the built-ins.

We should also inline the implementation of jsonpath, since it is trivial and doesn't make sense to externalize to the pkg repo.

This simplifies maintenance, because we don't have to worry about the pkg repo lifecycle as much.

Additional context

More info here: argoproj/argo-cd#22175


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@crenshaw-dev crenshaw-dev added the enhancement New feature or request label Mar 6, 2025
crenshaw-dev added a commit to crenshaw-dev/argo-events that referenced this issue Mar 6, 2025
crenshaw-dev added a commit that referenced this issue Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant