Restore support of breadcrumbs.enabled and workbench.editor.highlightModifiedTabs advanced settings

[kittaakos]

Describe the request

Originally from here:

Partially resolves:

• Some Theia settings have no effect, problematic decriptions, or are ignored on startup #1077

  • Everything reported in the issue is resolved except the following:

    • breadcrumbs.enabled has no effect
    • workbench.editor.highlightModifiedTabs has no effect

Reply from here:

• breadcrumbs.enabled has no effect

The breadcrumbs feature has been forcefully removed from IDE2.

• workbench.editor.highlightModifiedTabs has no effect

I do not know what's this.

I can create a follow-up with these items.

Closing with the following comments from here:

breadcrumbs.enabled has no effect

The breadcrumbs feature has been forcefully removed from IDE2.

If the settings are not expected to work, I think it is reasonable to explain that in #1077 and consider documenting the fact in the issue report to be sufficient. These settings are intended to be targeted exclusively to advanced users so we don't need to be so concerned about the user experience being polished.

I don't know whether any further action to improve on the current situation is possible.

workbench.editor.highlightModifiedTabs has no effect

I do not know what's this.

You can see the feature in effect in VS Code here (I am using the "Light+ (default light)" theme in the screenshot, but I also see the border in all the other themes I checked: "Dark (Visual Studio)", "Light (Visual Studio)", and "Dark High Contrast"):

---

Describe the current behavior

See the request description 👆

If restoring the lost features is trivial, this should be covered in this task. If it's not trivial or it causes performance issues, etc., then the reason for the missing features should be explained in #1077.

Arduino IDE version

5695fd8

Operating system

macOS, N/A

Operating system version

12.5.1

Additional context

Originally reported at #1077

Related

• Add support for window.titleBarStyle advanced setting #2716

Issue checklist

• I searched for previous requests in the issue tracker
• I verified the feature was still missing when using the latest nightly build
• My request contains all necessary details

[kittaakos]

• workbench.editor.highlightModifiedTabs has no effect

Upstream: eclipse-theia/theia#12185

[kittaakos]

From #2229 (comment):

Describe the request

the menu bar looks somewhat out of place if your theme's backgound differs from pure grey

Describe the current behavior

the menu bar is not effected by your theme

Arduino IDE version

2.2.1

Operating system

Windows

Operating system version

10

[per1234]

Since it is a significant and complex task on its own, which doesn't appear to be inherently linked to the task of enabling the breadcrumbs.enabled and workbench.editor.highlightModifiedTabs settings, I split the component of this issue regarding adding support for window.titleBarStyle to a dedicated issue: #2716, where it can be more effectively and efficiently tracked.