Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distinguish external headers #13

Open
Trass3r opened this issue Sep 26, 2019 · 2 comments
Open

distinguish external headers #13

Trass3r opened this issue Sep 26, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Trass3r
Copy link
Contributor

Trass3r commented Sep 26, 2019

I guess it could come in handy to have a separate section "Expensive external headers" for headers not coming from the current source tree. To find out which headers could easily go into a PCH.

Not sure about that though. If internal headers dominate like in llvm it's harder to use PCH.
@aras-p
Copy link
Owner

aras-p commented Sep 28, 2019

In completely arbitrary case it's kinda hard to know which headers are external vs which ones aren't. Like say if you have "your own" codebase, then some "3rd party libraries" that you also use, and then "STL" -- which ones are external? Clearly STL is, but are 3rd party libs also? How to tell them apart?

@aras-p aras-p added the enhancement New feature or request label Sep 28, 2019
@Lectem
Copy link
Contributor

Lectem commented Sep 28, 2019

I think include directories marked as -isystem would be a fit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aras-p @Trass3r @Lectem