Skip to content

Commit 089ed99

Browse files
committed
feat: remove the external url icon form the Link component
1 parent a9c1dba commit 089ed99

File tree

5 files changed

+1
-20
lines changed

5 files changed

+1
-20
lines changed

packages/keybr-widget/assets/open-in-new.svg

-4
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,3 @@
11
.root {
22
/* Empty. */
33
}
4-
5-
.external:dir(ltr) {
6-
padding-inline-end: 1.3rem;
7-
background: url(../../../assets/open-in-new.svg) no-repeat center right;
8-
background-size: 1rem;
9-
}
10-
11-
.external:dir(rtl) {
12-
padding-inline-end: 1.3rem;
13-
background: url(../../../assets/open-in-new.svg) no-repeat center left;
14-
background-size: 1rem;
15-
}

packages/keybr-widget/lib/components/text/Link.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export function Link({
1010
href,
1111
target,
1212
download,
13-
external,
1413
title,
1514
children,
1615
...props
@@ -19,7 +18,7 @@ export function Link({
1918
<Component
2019
{...props}
2120
id={id}
22-
className={clsx(styles.root, external && styles.external, className)}
21+
className={clsx(styles.root, className)}
2322
href={href}
2423
target={target}
2524
download={download}

packages/keybr-widget/lib/components/text/Link.types.ts

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ export type LinkProps = {
88
readonly href?: string;
99
readonly target?: string;
1010
readonly download?: string;
11-
readonly external?: boolean;
1211
readonly title?: string;
1312
readonly children?: ReactNode;
1413
} & MouseProps;

packages/page-practice/lib/settings/lesson/BenfordProp.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ export function BenfordProp(): ReactNode {
4040
<Link
4141
href="https://en.wikipedia.org/wiki/Benford's_law"
4242
target="_blank"
43-
external={true}
4443
>
4544
{chunks}
4645
</Link>

0 commit comments

Comments
 (0)