Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor table widget code base for clarity #39308

Open
12 of 13 tasks
Tracked by #2896
rahulbarwal opened this issue Feb 17, 2025 · 0 comments · May be fixed by #39367
Open
12 of 13 tasks
Tracked by #2896

Refactor table widget code base for clarity #39308

rahulbarwal opened this issue Feb 17, 2025 · 0 comments · May be fixed by #39367
Assignees
Labels
Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets Table Widget V2 Issues related to Table Widget V2 Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@rahulbarwal
Copy link
Contributor

rahulbarwal commented Feb 17, 2025

Basic idea is to move the context up from table body to table component and then make all the child components such as header, static table, virtual table and the respective body components use this new context. Thereby completely eliminating the need of table body component.

  • Central context in Table.tsx

  • Migrate Table header to use this new context.

  • Migrate static table

    • Migrate static body
  • Migrate virtual table

    • Migrate Row component
    • Migrate virtual body
    • Migrate infinite virtual body
  • Migrate Table column header

  • Migrate Header cell

  • Migrate Empty rows

  • Remove TableBody/index.tsx

  • Add unit tests for new components.

@rahulbarwal rahulbarwal added Table Widget V2 Issues related to Table Widget V2 Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets labels Feb 17, 2025
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators labels Feb 17, 2025
@rahulbarwal rahulbarwal self-assigned this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query & Widgets Pod All issues related to Query, JS, Eval, and Widgets Table Widget V2 Issues related to Table Widget V2 Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
1 participant