Skip to content

Support for alternative namers #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abingham opened this issue Nov 15, 2019 · 2 comments
Closed

Support for alternative namers #57

abingham opened this issue Nov 15, 2019 · 2 comments

Comments

@abingham
Copy link

The current "namer" system doesn't work for all scenarios. In particular, as related to #55, it can't take into account parametrized pytest tests; it produces the same name for each set of parameters.

ApprovalTests could support some system for adding (and activating) new namers that could handle special cases like that.

Is there any will in this project for a change like that, i.e. if I wrote it and submitted a PR?

@emilybache
Copy link
Contributor

I just submitted a change that should address this issue. I added a 'ScenarioNamer' class and associated unit test that demonstrates how to use it with parameterized pytest tests. Could you have a look and see if it does what you need?

@abingham
Copy link
Author

This seems to work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants