Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIOFileSystemFoundationCompat should provide Data(contentsOf:maximumSizeAllowed:) #2876

Open
weissi opened this issue Sep 10, 2024 · 0 comments

Comments

@weissi
Copy link
Member

weissi commented Sep 10, 2024

NIOFileSystem allows loading files into a ByteBuffer which is great for most purposes but there are still APIs (like Codable) that natively only want Datas. So NIOFileSytemFoundationCompat should provide Data(contentsOf:maximumSizeAllowed:).

clintonpi added a commit to clintonpi/swift-nio that referenced this issue Oct 14, 2024
Motivation:

As requested in issues [apple#2875](apple#2875) and [apple#2876](apple#2876), it would be convenient to be able to read the contents of a file into more data types such as `Array`, `ArraySlice` & Foundation's `Data`.

Modifications:

- Extend `Array`, `ArraySlice` & `Data` to be initialisable with the contents of a file.

Result:

The contents of a file can be read into more data types.
glbrntt added a commit that referenced this issue Oct 21, 2024
Motivation:

As requested in issues
[#2875](#2875) and
[#2876](#2876), it would be
convenient to be able to read the contents of a file into more data
types such as `Array`, `ArraySlice` & Foundation's `Data`.

Modifications:

- Extend `Array`, `ArraySlice` & `Data` to be initialisable with the
contents of a file.

Result:

The contents of a file can be read into more data types.

---------

Co-authored-by: George Barnett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant