Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% coverage #25

Open
sushain97 opened this issue Mar 22, 2018 · 3 comments
Open

100% coverage #25

sushain97 opened this issue Mar 22, 2018 · 3 comments

Comments

@sushain97
Copy link
Member

sushain97 commented Mar 22, 2018

https://coveralls.io/builds/16163088/source?filename=streamparser.py

there are a couple uncovered lines ;)

@sushain97
Copy link
Member Author

sushain97 commented Apr 18, 2018

@unhammer could you weigh in with some strings that could cover those last couple of branches?

@sushain97
Copy link
Member Author

oops, accidentally closed

@sushain97 sushain97 reopened this Apr 18, 2018
@unhammer
Copy link
Member


111 | if buf != '': | Branches [[0, 112]] missed. 5×
-- | -- | --
112 | tags.append(buf) | !

would happen if _parse_tags gets an empty string, right? (So _parse_subreading would have to return something empty as second element.) Would ^foo/bar/fie$ do it? And maybe ^foo$ for the empty buf test in _parse_subreading? (Though I think that one should be caught by line 171)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants