Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No integration test coverage for object-storage code path #1072

Open
snazy opened this issue Feb 26, 2025 · 2 comments
Open

No integration test coverage for object-storage code path #1072

snazy opened this issue Feb 26, 2025 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@snazy
Copy link
Member

snazy commented Feb 26, 2025

Describe the bug

Code paths for object-storages like S3, GCS or Azure do not have integration test coverage.

At a very minimum, the following needs integration testing:

  • S3 against Minio + STS/IAM
  • GCS against e.g. fake-gcs-server
  • Azure against e.g. Azurite

To Reproduce

No response

Actual Behavior

No response

Expected Behavior

No response

Additional context

No response

System information

No response

@eric-maynard
Copy link
Contributor

A lack of test coverage is not a bug

@eric-maynard eric-maynard removed the bug Something isn't working label Mar 4, 2025
@flyrain flyrain added this to the 1.1.0 milestone Mar 13, 2025
@flyrain
Copy link
Contributor

flyrain commented Mar 13, 2025

Thanks for reporting. It's important to have these integration tests. Minio + STS/IAM is working in progress, details are in #389. Once #389 was merged, we could start to build integration tests on it. That said, I think it's not a 1.0 blocker. I'm also not sure we could get this done in the timeline of 1.0, mark it as 1.1.0

@flyrain flyrain added enhancement New feature or request and removed 1.0-blocker labels Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants