Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for CMake and/or pkgconfig package data by default #2147

Open
h-vetinari opened this issue Mar 7, 2025 · 0 comments
Open

Search for CMake and/or pkgconfig package data by default #2147

h-vetinari opened this issue Mar 7, 2025 · 0 comments

Comments

@h-vetinari
Copy link
Contributor

Orc should recognize CMake / pkgconfig metadata for dependencies, ideally by default. In conda-forge/arrow-cpp-feedstock#1697, we had to add

      -DLZ4_HOME="%LIBRARY_PREFIX%" ^
      -DLZ4_INCLUDE_DIR="%LIBRARY_INC%" ^
      -DLZ4_LIBRARY="%LIBRARY_LIB%\lz4.lib" ^
      -DZSTD_HOME="%LIBRARY_PREFIX%" ^
      -DZSTD_INCLUDE_DIR="%LIBRARY_INC%" ^
      -DZSTD_LIBRARY="%LIBRARY_LIB%\libzstd.lib" ^

otherwise orc would fail to find its dependencies. That should not be necessary, as conda-forge has complete metadata for those packages, and so orc should search first try to look in CMAKE_MODULE_PATH, PKG_CONFIG_PATH (and ideally just $PREFIX / CMAKE_PREFIX_PATH) before falling back to testing ZSTD_* / LZ4_* / ... variables (and eventually failing if the dependencies really cannot be found anywhere).

From my POV think this is healthy default behaviour in general, but if you prefer, you can also put this behind some choice of -DORC_PACKAGE_KIND=. Based on the suggestion of @wgtmac, I tried this (shortly before the release of 2.1.1) in conda-forge/orc-feedstock#86, and the existing "conan" / "vcpkg" options do not work for this purpose.

@h-vetinari h-vetinari changed the title Depend on CMake and/or pkgconfig package data by default Search for CMake and/or pkgconfig package data by default Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant