You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
otherwise orc would fail to find its dependencies. That should not be necessary, as conda-forge has complete metadata for those packages, and so orc should search first try to look in CMAKE_MODULE_PATH, PKG_CONFIG_PATH (and ideally just $PREFIX / CMAKE_PREFIX_PATH) before falling back to testing ZSTD_* / LZ4_* / ... variables (and eventually failing if the dependencies really cannot be found anywhere).
From my POV think this is healthy default behaviour in general, but if you prefer, you can also put this behind some choice of -DORC_PACKAGE_KIND=. Based on the suggestion of @wgtmac, I tried this (shortly before the release of 2.1.1) in conda-forge/orc-feedstock#86, and the existing "conan" / "vcpkg" options do not work for this purpose.
The text was updated successfully, but these errors were encountered:
h-vetinari
changed the title
Depend on CMake and/or pkgconfig package data by default
Search for CMake and/or pkgconfig package data by default
Mar 7, 2025
Orc should recognize CMake / pkgconfig metadata for dependencies, ideally by default. In conda-forge/arrow-cpp-feedstock#1697, we had to add
otherwise orc would fail to find its dependencies. That should not be necessary, as conda-forge has complete metadata for those packages, and so orc should search first try to look in
CMAKE_MODULE_PATH
,PKG_CONFIG_PATH
(and ideally just$PREFIX
/CMAKE_PREFIX_PATH
) before falling back to testingZSTD_*
/LZ4_*
/ ... variables (and eventually failing if the dependencies really cannot be found anywhere).From my POV think this is healthy default behaviour in general, but if you prefer, you can also put this behind some choice of
-DORC_PACKAGE_KIND=
. Based on the suggestion of @wgtmac, I tried this (shortly before the release of 2.1.1) in conda-forge/orc-feedstock#86, and the existing"conan"
/"vcpkg"
options do not work for this purpose.The text was updated successfully, but these errors were encountered: