Skip to content

Commit f96d345

Browse files
committed
ORC-1837: Remove commons-csv from parent pom.xml
### What changes were proposed in this pull request? This PR aims to remove `commons-csv` from parent `pom.xml`. ### Why are the changes needed? We can remove `commons-csv` from the parent pom file. - `commons-cvs` is used in `bench` module only and it's defined in `pom.xml` of `bench` module already. - `opencsv` is used in `tools` ``` $ git grep csv | grep import bench/core/src/java/org/apache/orc/bench/core/convert/GenerateVariants.java:import org.apache.orc.bench.core.convert.csv.CsvReader; bench/core/src/java/org/apache/orc/bench/core/convert/csv/CsvReader.java:import org.apache.commons.csv.CSVFormat; bench/core/src/java/org/apache/orc/bench/core/convert/csv/CsvReader.java:import org.apache.commons.csv.CSVParser; bench/core/src/java/org/apache/orc/bench/core/convert/csv/CsvReader.java:import org.apache.commons.csv.CSVRecord; tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import com.opencsv.CSVParser; tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import com.opencsv.CSVParserBuilder; tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import com.opencsv.CSVReader; tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import com.opencsv.CSVReaderBuilder; tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import com.opencsv.exceptions.CsvValidationException; ``` ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2114 from dongjoon-hyun/ORC-1837. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 0456efa) Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent c89e7a2 commit f96d345

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

java/pom.xml

-5
Original file line numberDiff line numberDiff line change
@@ -162,11 +162,6 @@
162162
<artifactId>zstd-jni</artifactId>
163163
<version>${zstd-jni.version}</version>
164164
</dependency>
165-
<dependency>
166-
<groupId>org.apache.commons</groupId>
167-
<artifactId>commons-csv</artifactId>
168-
<version>1.12.0</version>
169-
</dependency>
170165
<dependency>
171166
<groupId>org.apache.hadoop</groupId>
172167
<artifactId>hadoop-client-api</artifactId>

0 commit comments

Comments
 (0)