Skip to content

Commit b5c4e0b

Browse files
douarddadongjoon-hyun
authored andcommitted
ORC-1618: Disable building tests for snappy
Disabling the building of tests is a workaround for issue #1791 and is probably not an issue since snappy tests are not executed as part of the build process of orc c++ libs. Note that snappy 1.1.9 and 1.1.10 cannot be used as is because source assets on snappy's gh page are not buildable out of the box, so stick to 1.1.8 for now. ### What changes were proposed in this pull request? Disable building snappy tests as a workaround for issue #1791. ### Why are the changes needed? compilation broken in some situations otherwise (see issue) ### How was this patch tested? compile & unit tests ### Was this patch authored or co-authored using generative AI tooling? no Closes #1792 from douardda/fix-snappy. Authored-by: David Douard <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9627a24) Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent 5bf5227 commit b5c4e0b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cmake_modules/ThirdpartyToolchain.cmake

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ else ()
8787

8888
ExternalProject_Add (snappy_ep
8989
URL "https://github.com/google/snappy/archive/${SNAPPY_VERSION}.tar.gz"
90-
CMAKE_ARGS ${SNAPPY_CMAKE_ARGS}
90+
CMAKE_ARGS ${SNAPPY_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF
9191
${THIRDPARTY_LOG_OPTIONS}
9292
BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")
9393

0 commit comments

Comments
 (0)