Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support random access byte/float vector values as first class part of API #13778

Open
msokolov opened this issue Sep 12, 2024 · 0 comments
Open

Comments

@msokolov
Copy link
Contributor

Description

While working on implementing BP reordering over vectors, the idea came up that we might be able to simplify our APIs by surfacing random access to vector values. Today it exists and every vector reader implements it, but the API hides it behind an interface (RandomAccessVectorValues) that requires casting to access it. I'm opening this issue to see how that might look and get feedback. This is intended to be a refactor that would make it easier to maintain and enhance these classes and shouldn't introduce functional changes.

cbuescher added a commit to cbuescher/lucene that referenced this issue Sep 18, 2024
Addresses apache#13778

TermInSetQuery used to have an accessor to its terms that was removed in apache#12173
to protect leaking internal encoding details. This introduces an accessor to the
term data in the query that doesn't expose internal but merely allows iterating
over the decoded BytesRef, making inspection of the querys content possible again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant