Skip to content

Commit f2cacd3

Browse files
committed
[KYUUBI #6836] Ship kafka-clients in binary distribution tarball without compression libs
### Why are the changes needed? I'd like to include `kafka-clients` in the Kyuubi binary distribution tarball to enable the out-of-box support for sinking Kyuubi events to Kafka. - Kafka is an important component in modern data platforms, and is a defacto message queue implementation, especially in the big data domain - `kafka-clients` is released under Apache License V2, has no legal issue - `kafka-clients` is quite a light lib, has no third-party deps except for `slf4j-api` and a few optional compression libs - `kafka-clients` uses "none" compression as default, in practice, "gzip"(delegate to JDK gzip algorithm, no additional libs are required) already performs well for non-extreme cases Additionally, LOG4J2 has a built-in `KafkaAppender` that supports sinking logging to Kafka, which also requires `kafka-clients` in the classpath, I have some initial ideas to forward both Kyuubi server's and engine bootstrap processes log to Kafka in a structured format, will send another PR to add docs to guide users in configuring that. ### How was this patch tested? Review ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6836 from pan3793/kafka-lib. Closes #6836 b069eb1 [Cheng Pan] Ship kafka-clients in binary distribution tarball without compression libs Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
1 parent 9c8b2c3 commit f2cacd3

File tree

4 files changed

+14
-23
lines changed

4 files changed

+14
-23
lines changed

LICENSE-binary

-3
Original file line numberDiff line numberDiff line change
@@ -306,8 +306,6 @@ io.vertx:vertx-grpc
306306
com.squareup.retrofit2:retrofit
307307
com.squareup.okhttp3:okhttp
308308
org.apache.kafka:kafka-clients
309-
org.lz4:lz4-java
310-
org.xerial.snappy:snappy-java
311309
org.xerial:sqlite-jdbc
312310

313311
BSD
@@ -319,7 +317,6 @@ jline:jline
319317
com.thoughtworks.paranamer:paranamer
320318
com.google.protobuf:protobuf-java-util
321319
com.google.protobuf:protobuf-java
322-
com.github.luben:zstd-jni
323320
org.postgresql:postgresql
324321

325322
Eclipse Distribution License - v 1.0

NOTICE-binary

-16
Original file line numberDiff line numberDiff line change
@@ -1063,19 +1063,3 @@ which can be obtained at:
10631063
* license/LICENSE.kafka.txt (Apache License 2.0)
10641064
* HOMEPAGE:
10651065
* https://github.com/apache/kafka
1066-
1067-
This product optionally depends on 'snappy-java', Snappy compression and
1068-
decompression for Java, which can be obtained at:
1069-
1070-
* LICENSE:
1071-
* license/LICENSE.snappy-java.txt (Apache License 2.0)
1072-
* HOMEPAGE:
1073-
* https://github.com/xerial/snappy-java
1074-
1075-
This product optionally depends on 'lz4-java', Lz4 compression and
1076-
decompression for Java, which can be obtained at:
1077-
1078-
* LICENSE:
1079-
* license/LICENSE.lz4-java.txt (Apache License 2.0)
1080-
* HOMEPAGE:
1081-
* https://github.com/lz4/lz4-java

dev/dependencyList

-3
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ log4j-api/2.24.2//log4j-api-2.24.2.jar
128128
log4j-core/2.24.2//log4j-core-2.24.2.jar
129129
log4j-slf4j-impl/2.24.2//log4j-slf4j-impl-2.24.2.jar
130130
logging-interceptor/3.12.12//logging-interceptor-3.12.12.jar
131-
lz4-java/1.8.0//lz4-java-1.8.0.jar
132131
metrics-core/4.2.26//metrics-core-4.2.26.jar
133132
metrics-jmx/4.2.26//metrics-jmx-4.2.26.jar
134133
metrics-json/4.2.26//metrics-json-4.2.26.jar
@@ -173,7 +172,6 @@ simpleclient_tracer_otel_agent/0.16.0//simpleclient_tracer_otel_agent-0.16.0.jar
173172
slf4j-api/1.7.36//slf4j-api-1.7.36.jar
174173
snakeyaml-engine/2.7//snakeyaml-engine-2.7.jar
175174
snakeyaml/2.2//snakeyaml-2.2.jar
176-
snappy-java/1.1.10.5//snappy-java-1.1.10.5.jar
177175
sqlite-jdbc/3.46.1.3//sqlite-jdbc-3.46.1.3.jar
178176
swagger-annotations/2.2.1//swagger-annotations-2.2.1.jar
179177
swagger-core/2.2.1//swagger-core-2.2.1.jar
@@ -185,4 +183,3 @@ units/1.7//units-1.7.jar
185183
vertx-core/4.5.3//vertx-core-4.5.3.jar
186184
vertx-grpc/4.5.3//vertx-grpc-4.5.3.jar
187185
zjsonpatch/0.3.0//zjsonpatch-0.3.0.jar
188-
zstd-jni/1.5.5-1//zstd-jni-1.5.5-1.jar

pom.xml

+14-1
Original file line numberDiff line numberDiff line change
@@ -1053,7 +1053,20 @@
10531053
<groupId>org.apache.kafka</groupId>
10541054
<artifactId>kafka-clients</artifactId>
10551055
<version>${kafka.version}</version>
1056-
<optional>true</optional>
1056+
<exclusions>
1057+
<exclusion>
1058+
<groupId>com.github.luben</groupId>
1059+
<artifactId>zstd-jni</artifactId>
1060+
</exclusion>
1061+
<exclusion>
1062+
<groupId>org.lz4</groupId>
1063+
<artifactId>lz4-java</artifactId>
1064+
</exclusion>
1065+
<exclusion>
1066+
<groupId>org.xerial.snappy</groupId>
1067+
<artifactId>snappy-java</artifactId>
1068+
</exclusion>
1069+
</exclusions>
10571070
</dependency>
10581071

10591072
<dependency>

0 commit comments

Comments
 (0)